Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53861

PHP notices on (2.5) behat execution when checked versions do not match

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Behat should check for different php versions.

      1. Change your cli php version to be different from web php version (use phpbrew)
      2. Run behat and it should show differences (Differences detected between cli and webserver...)
      3. Ensure no debug message is shown.

      NOTE: Would be nice to test it with xdebug enabled.

      Show
      Behat should check for different php versions. Change your cli php version to be different from web php version (use phpbrew) Run behat and it should show differences (Differences detected between cli and webserver...) Ensure no debug message is shown. NOTE: Would be nice to test it with xdebug enabled.
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE

      Description

      This is a followup of MDL-52502, where a un-noticed php notice happen in stables when there are version mismatches. To reproduce it:

      0) With 29 or 30 branches (aka, behat 2.5), cannot reproduce it with master (behat 3.x).
      1) enable xdebug (to make it more obvious, because stack trace will be printed).
      2) set your PHP CLI version slightly different to the web server one.
      3) run behat

      Expected behavior:

      1) Differences should be shown and behat start.

      Current behavior:

      0) A PHP notice (and stack trace) is printed about (unpaired) ob_flush()
      1) Differences should be shown and behat start.

      Output with xdebug disabled and enabled.

      Ciao

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/May/16