Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53861

PHP notices on (2.5) behat execution when checked versions do not match

    XMLWordPrintable

Details

    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • Hide

      Behat should check for different php versions.

      1. Change your cli php version to be different from web php version (use phpbrew)
      2. Run behat and it should show differences (Differences detected between cli and webserver...)
      3. Ensure no debug message is shown.

      NOTE: Would be nice to test it with xdebug enabled.

      Show
      Behat should check for different php versions. Change your cli php version to be different from web php version (use phpbrew) Run behat and it should show differences (Differences detected between cli and webserver...) Ensure no debug message is shown. NOTE: Would be nice to test it with xdebug enabled.

    Description

      This is a followup of MDL-52502, where a un-noticed php notice happen in stables when there are version mismatches. To reproduce it:

      0) With 29 or 30 branches (aka, behat 2.5), cannot reproduce it with master (behat 3.x).
      1) enable xdebug (to make it more obvious, because stack trace will be printed).
      2) set your PHP CLI version slightly different to the web server one.
      3) run behat

      Expected behavior:

      1) Differences should be shown and behat start.

      Current behavior:

      0) A PHP notice (and stack trace) is printed about (unpaired) ob_flush()
      1) Differences should be shown and behat start.

      Output with xdebug disabled and enabled.

      Ciao

      Attachments

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-53796 get_debug_text function not defined

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-54553 Notices when webserver problem with behat

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-52502 Inject the php version used in phpunit/behat tests (nice to have) and ensure environment is same between behat web/cli

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-54019 'decteted' typo in behat

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              rajeshtaneja Rajesh Taneja
              stronk7 Eloy Lafuente (stronk7)
              Mark Nelson Mark Nelson
              Dan Poltawski Dan Poltawski
              Ryan Wyllie Ryan Wyllie
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/May/16