Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53891

bootstrap AMD module executes immediately - even if it is not called

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_30_STABLE

      Description

      The contents of first.js seems to include AMD modules from all themes currently installed, I would have expected only the current theme modules to be loaded.

      Previous discussion:
      https://moodle.org/mod/forum/discuss.php?d=325073

      Unlike other modules, there's no mechanism to have themes installed but "hidden" by clicking an eye icon, so to avoid this happening it seems like you need to physically remove the theme from the disk. Doing this to bootstrapbase seems unwise since it's part of core Moodle, and it wasn't previously something that needed to be done for other installed themes.

      If a future version of Moodle ships with both a Bootstrap 4 default theme, and Bootstrapbase for backwards compatability, the two versions of the Bootstrap js would both be loaded by themes that use either as a parent theme.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              bawjaws David Scotson
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
              Votes:
              4 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated: