Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53894

increase length of course idnumber db field from 100 to 255 characters

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.1, 3.3.3, 3.4
    • Fix Version/s: None
    • Component/s: Course, Database SQL/XMLDB
    • Labels:
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-53894_master
    • Testing Instructions:
      Hide
      Test 1
      1. Install a fresh site using integration master.
      2. Check the ‘course’ table and ensure the following -
        1. The ‘fullname’ field is 255 characters in length.
        2. The ‘shortname’ field is 255 characters in length.
        3. The ‘idnumber’ field is 255 characters in length.
      3. Check the ‘course_request’ table and ensure the following -
        1. The ‘fullname’ field is 255 characters in length.
        2. The ‘shortname’ field is 255 characters in length.
      4. Check the ‘mnetservice_enrol_courses’ table and ensure the following -
        1. The ‘fullname’ field is 255 characters in length.
        2. The ‘shortname’ field is 255 characters in length.
        3. The ‘idnumber’ field is 255 characters in length.
      Test 2
      1. Install a Moodle 3.4 site.
      2. Upgrade to latest integration.
      3. Check the ‘course’ table and ensure the following -
        1. The ‘fullname’ field is 255 characters in length.
        2. The ‘shortname’ field is 255 characters in length.
        3. The ‘idnumber’ field is 255 characters in length.
        4. The 'shortname' is an index.
        5. The 'idnumber' is an index.
      4. Check the ‘course_request’ table and ensure the following -
        1. The ‘fullname’ field is 255 characters in length.
        2. The ‘shortname’ field is 255 characters in length.
        3. The 'shortname' is an index.
      5. Check the ‘mnetservice_enrol_courses’ table and ensure the following -
        1. The ‘fullname’ field is 255 characters in length.
        2. The ‘shortname’ field is 255 characters in length.
        3. The ‘idnumber’ field is 255 characters in length.
      Test 3
      1. Create a course with text in shortname, fullname and idnumber that is 255 characters long and ensure it saves successfully (re-edit to confirm):

        Lorem ipsum dolor sit amet, nonummy ligula volutpat hac integer nonummy. Suspendisse ultricies, congue etiam tellus, erat libero, nulla eleifend, mauris pellentesque. Suspendisse integer praesent vel, integer gravida mauris, fringilla vehicula lacinia non
        

      Test 4
      1. Log in as an admin.
      2. Enable course requests.
      3. Log in as a student of a course.
      4. Visit <yoursite>/course/index.php.
      5. Click on ‘Request a course’.
      6. Create a course with text in shortname and fullname that is 255 characters long and ensure it saves successfully in the 'course_request' table (check DB fields to confirm):

        Lorem ipsum dolor sit amet, nonummy ligula volutpat hac integer nonummy. Suspendisse ultricies, congue etiam tellus, erat libero, nulla eleifend, mauris pellentesque. Suspendisse integer praesent vel, integer gravida mauris, fringilla vehicula lacinia non
        

      Show
      Test 1 Install a fresh site using integration master. Check the ‘course’ table and ensure the following - The ‘fullname’ field is 255 characters in length. The ‘shortname’ field is 255 characters in length. The ‘idnumber’ field is 255 characters in length. Check the ‘course_request’ table and ensure the following - The ‘fullname’ field is 255 characters in length. The ‘shortname’ field is 255 characters in length. Check the ‘mnetservice_enrol_courses’ table and ensure the following - The ‘fullname’ field is 255 characters in length. The ‘shortname’ field is 255 characters in length. The ‘idnumber’ field is 255 characters in length. Test 2 Install a Moodle 3.4 site. Upgrade to latest integration. Check the ‘course’ table and ensure the following - The ‘fullname’ field is 255 characters in length. The ‘shortname’ field is 255 characters in length. The ‘idnumber’ field is 255 characters in length. The 'shortname' is an index. The 'idnumber' is an index. Check the ‘course_request’ table and ensure the following - The ‘fullname’ field is 255 characters in length. The ‘shortname’ field is 255 characters in length. The 'shortname' is an index. Check the ‘mnetservice_enrol_courses’ table and ensure the following - The ‘fullname’ field is 255 characters in length. The ‘shortname’ field is 255 characters in length. The ‘idnumber’ field is 255 characters in length. Test 3 Create a course with text in shortname, fullname and idnumber that is 255 characters long and ensure it saves successfully (re-edit to confirm): Lorem ipsum dolor sit amet, nonummy ligula volutpat hac integer nonummy. Suspendisse ultricies, congue etiam tellus, erat libero, nulla eleifend, mauris pellentesque. Suspendisse integer praesent vel, integer gravida mauris, fringilla vehicula lacinia non Test 4 Log in as an admin. Enable course requests. Log in as a student of a course. Visit <yoursite>/course/index.php. Click on ‘Request a course’. Create a course with text in shortname and fullname that is 255 characters long and ensure it saves successfully in the 'course_request' table (check DB fields to confirm): Lorem ipsum dolor sit amet, nonummy ligula volutpat hac integer nonummy. Suspendisse ultricies, congue etiam tellus, erat libero, nulla eleifend, mauris pellentesque. Suspendisse integer praesent vel, integer gravida mauris, fringilla vehicula lacinia non

      Description

      increase length of course idnumber db field from 100 to 255 characters
      increase length of course fullname db field from 254->255 characters

      also up form maxlength for idnumber and shortname from 100->255 and increase visible form length of shortname and idnumber from 20->45

      Andrew nichols suggested in chat for an epic to make all text fields consistent at 255 chars, this could be part of that

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              berserkk Ben Kelada
              Peer reviewer:
              Mark Nelson Mark Nelson
              Integrator:
              Damyon Wiese Damyon Wiese
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated: