Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.9.5, 3.0
-
Component/s: Authentication
-
Testing Instructions:
-
Affected Branches:MOODLE_29_STABLE, MOODLE_30_STABLE
-
Fixed Branches:MOODLE_29_STABLE, MOODLE_30_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-53901-master -
Pull Master Diff URL:
Description
When the site is using HTTPS for logins, if the user passes an incorrrect password or some other error is generated on login the login/index.php file redirects the user to a HTTP URL. The site then, because of the use HTTPS for login, redirects the user again to the HTTPS URL for login.
This is being caused by the redirect in line 355 (in Moodle 2.9) of login/index.php
{quote}} else if ($errormsg or !empty($frm->password)) {
// We must redirect after every password submission.
if ($errormsg)
redirect(new moodle_url('/login/index.php'));
}
redirect(new moodle_url($CFG->httpswwwroot . '/login/index.php');If this is changed to:
this fixes the double redirect. This is already used in several places in the file.