[MDL-53945] MNet wont work if $CFG->admin is changed. - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Pull from Repository:
git://github.com/aolley/moodle.git
Pull Master Branch:
~~MDL-53945~~
Pull Master Diff URL:
https://github.com/aolley/moodle/compare/moodle:master...MDL-53945
Testing Instructions:

Hide

Rename your admin directory to something else, like "myadmin"
Set: $CFG->admin = 'myadmin'; in your config.php file.
Visit the urls under Site administration > Networking.
Test adding a mnet peer to your site

Show
Rename your admin directory to something else, like "myadmin" Set: $CFG->admin = 'myadmin'; in your config.php file. Visit the urls under Site administration > Networking. Test adding a mnet peer to your site

All calls in mnet like this:

require_once($CFG->dirroot . '/admin/mnet/tabs.php');

Should be like this:

require_once($CFG->dirroot . '/' . $CFG->admin . '/mnet/tabs.php');

Testing discovered

MDL-56726 $CFG->admin ignored when requiring other scripts

MDL-56788 Boost admin renderer hard codes admin path

Participants:: Adam Olley, Adrian Greeve, CiBoT, Damyon Wiese, Dan Poltawski, David Mudrák (@mudrd8mz)