Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53985

Assignment feedback is deleted when assignment reverted to draft

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.1, 3.0.2, 3.4
    • Fix Version/s: 3.3.4, 3.4.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Create an assignment that allows only file submissions and has "Annotate PDF" feedback enabled and requires students to click submit button.

      As a student upload a PDF file.
      As a student "submit" the assignment submission.

      As a teacher, grade the student and draw something over the PDF.
      As a teacher, from the "View all submisssion" table for the assignment, revert this students submission to draft.
      Grade the student again and verify you can still see the annotations on the file.

      Show
      Create an assignment that allows only file submissions and has "Annotate PDF" feedback enabled and requires students to click submit button. As a student upload a PDF file. As a student "submit" the assignment submission. As a teacher, grade the student and draw something over the PDF. As a teacher, from the "View all submisssion" table for the assignment, revert this students submission to draft. Grade the student again and verify you can still see the annotations on the file.
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-53985-master
    • Pull Master Diff URL:

      Description

      • Open assignment grading page.
      • Enter feedback.
      • Select Revert To Draft.
      • Save.
      • Feedback is deleted.

      When an assignment submission is reverted to a draft, the timemodified on
      the submission should not be modified. Changing the timemodified causes the
      editpdf code to assume the pdf is stale, and forces all annotations to be removed.

        Attachments

          Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45580 PDF Annotations Remain After PDF is Replaced

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              emmarichardson Emma Richardson
              Peer reviewer:
              Jun Pataleta
              Integrator:
              Andrew Nicols
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jan/18