Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53988

LTI admin screen follow-up

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Add a tool registration via a url (e.g.http://lti.tools/test/tp.php and https://online.dr-chuck.com/sakai-api-test/tp.php )
      2. Click on Manage Tools in the navbar/breadcrumb so the page goes back. (Don’t click cancel)
      3. You should see a tool called “Tool provider”.
      4. Try to edit it
      5. Try deleting it but cancel. Verify nothing happens.
      6. Actually delete it
      7. Add another tool and go back to the tool configure page by clicking Manage Tools in the navbar
      8. Click confirm
      9. You should be shown the iframe again
      10. Select some capabilities and say register tool
      11. The tool should be added to the tool list
      12. Try to rename the tool using in place editing, to verify it worked as expected.
      13. Try deleting it but cancel. Verify nothing happens.
      14. Actually delete it
      15. Add the tool again via a URL, but this time complete the steps without going back to the configure page until it is done.
      16. Try renaming the tool via in place editing, to verify it worked as expected.
      17. Add another tool with the same url. An error should display above the
      18. Try adding a tool from an invalid URL (e.g. http://www.w3schools.com/xml/note.xml)
      Show
      Add a tool registration via a url (e.g. http://lti.tools/test/tp.php and https://online.dr-chuck.com/sakai-api-test/tp.php ) Click on Manage Tools in the navbar/breadcrumb so the page goes back. (Don’t click cancel) You should see a tool called “Tool provider”. Try to edit it Try deleting it but cancel. Verify nothing happens. Actually delete it Add another tool and go back to the tool configure page by clicking Manage Tools in the navbar Click confirm You should be shown the iframe again Select some capabilities and say register tool The tool should be added to the tool list Try to rename the tool using in place editing, to verify it worked as expected. Try deleting it but cancel. Verify nothing happens. Actually delete it Add the tool again via a URL, but this time complete the steps without going back to the configure page until it is done. Try renaming the tool via in place editing, to verify it worked as expected. Add another tool with the same url. An error should display above the Try adding a tool from an invalid URL (e.g. http://www.w3schools.com/xml/note.xml )
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-53988-master

      Description

      In order to get all issues passing and to keep integrators sane I decided to create a follow-up issue for MDL-52154. My main points during testing were mainly aesthetic, so there is nothing major that I believe needs urgent reverting at this time. As well as John Okely being away for the day and passing this to Ryan Wyllie we also had no power at the office for the whole day so it's not safe to assume this can be done before integrators want to release.

      John has responded to my comments and provided a patch (not complete) so please view MDL-52154 for more detail.

      Outstanding issues

      1. If I enter in a wrong url (eg. http:/asdasd12341.com) I get two warnings.
      2. Should I not get a warning about deleting a tool if it is in use? Seems like someone could potentially mess up a whole course.
      3. I got the duplicate URL error 'This registration URL is already in use' even though it stated 'There are no external tools configured'.
      4. I could not see how to add another tool for a while before realising I had to close the success message or refresh the page.
      5. When adding a tool (in this case I just used http://example.com) I was taken to a page with just the button 'Cancel' displayed at the top and was not really sure what else I had to do before I realised I had to click on 'configure a tool manually' on the previous page. - We could use an Add button that people can press if they can tell it's a launch url not a configuration URL. But it may confuse people who are trying to set up a tool via a configuration url
      6. When adding 'http://www.w3schools.com/xml/note.xml' I get asked about a Consumer and Shared key then get told the URL is bad - should this not be done beforehand?

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16