Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53994

Feedback block broken on 3.1 upgrade

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide

      Run the behat scenario:

      --name 'Site feedback deletion hides feedback block completely'

      with the patch applied it passes.

      Without the require_once() added by the patch, it fails.

      Let CI to run the complete phpunit/behat tests, all them should pass, this is not expected to introduce any regression.

      Show
      Run the behat scenario: --name 'Site feedback deletion hides feedback block completely' with the patch applied it passes. Without the require_once() added by the patch, it fails. Let CI to run the complete phpunit/behat tests, all them should pass, this is not expected to introduce any regression.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      From the chat:

      15:36:37 Mary Cooch: help!!
      15:36:49 Dan P: whats up?
      15:36:49 Mary Cooch: I just upgraded my 3.1 dev site and it is broken
      15:37:41 Mary Cooch: Fatal error: Call to undefined function feedback_get_feedbacks_from_sitecourse_map() in /var/www/vhosts/geographydiva.com/httpdocs/moodle/blocks/feedback/block_feedback.php on line 59

      Looks to me like like it was caused by this removal:
      https://github.com/moodle/moodle/commit/aeeeb78847ed0121a835a476f219c4cf4be99f92#diff-49d6c8324b4d4197171d657a07cd6eb8L25

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16