Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-5400

Accessibility modifications not propagated to themes

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6, 1.7, 1.8, 1.9
    • Fix Version/s: 1.7.3, 1.8.3, 1.9
    • Component/s: Accessibility, Themes
    • Labels:
      None
    • Environment:
      All

      Description

      There are 14 themes in Moodle 1.6 beta. A quick search reveals that of these, only 3 use H1 to markup headermain: Chameleon, Oceanblue and Standard.

      8 still use a 1-cell <table> to layout the navbar/breadcrumb trail, in header.html.

      Also, 2 use a <table> for the navbar/breadcrumb trail, in footer.html: Oceanblue and Standard (not sure if these are ever displayed, but better fix them).

      To the theme maintainers who have implemented accessibility Markup changes, well done. It would be great if the rest could follow suit, thanks.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment -

            From Nick Freear (n.d.freear at open.ac.uk) Tuesday, 2 May 2006, 10:37 PM:

            Ongoing, fix in http://moodle.cvs.sourceforge.net/moodle/moodle/theme/standard/footer.html - Easy, no change required to style sheets.

            From Nick Freear (n.d.freear at open.ac.uk) Tuesday, 2 May 2006, 10:46 PM:

            Ongoing, fixes for headermain and <table> in http://moodle.cvs.sourceforge.net/moodle/moodle/theme/standardwhite/header.html - Easy, no change required to style sheets!

            From Nick Freear (n.d.freear at open.ac.uk) Monday, 22 May 2006, 06:20 PM:

            Ongoing, fixes for headermain and <table> in http://moodle.cvs.sourceforge.net/moodle/moodle/theme/standardlogo/header.html - Easy, no change required to style sheets!

            'standarlogo' fixed on branch, merged.

            Show
            dougiamas Martin Dougiamas added a comment - From Nick Freear (n.d.freear at open.ac.uk) Tuesday, 2 May 2006, 10:37 PM: Ongoing, fix in http://moodle.cvs.sourceforge.net/moodle/moodle/theme/standard/footer.html - Easy, no change required to style sheets. From Nick Freear (n.d.freear at open.ac.uk) Tuesday, 2 May 2006, 10:46 PM: Ongoing, fixes for headermain and <table> in http://moodle.cvs.sourceforge.net/moodle/moodle/theme/standardwhite/header.html - Easy, no change required to style sheets! From Nick Freear (n.d.freear at open.ac.uk) Monday, 22 May 2006, 06:20 PM: Ongoing, fixes for headermain and <table> in http://moodle.cvs.sourceforge.net/moodle/moodle/theme/standardlogo/header.html - Easy, no change required to style sheets! 'standarlogo' fixed on branch, merged.
            Hide
            nfreear Nick Freear added a comment -

            Hi Urs. I hope you don't mind me taking this old issue on! Of the 15 themes in the standard 'moodle' installation, none now use <table> for layout, and only 4 do not use <h1>. This patch is for those 4:

            • cornflower, metal, orangewhite, orangewhitepda
            Show
            nfreear Nick Freear added a comment - Hi Urs. I hope you don't mind me taking this old issue on! Of the 15 themes in the standard 'moodle' installation, none now use <table> for layout, and only 4 do not use <h1>. This patch is for those 4: cornflower, metal, orangewhite, orangewhitepda
            Hide
            nfreear Nick Freear added a comment -

            I've committed fixes to the 4 header.html on HEAD, 1.8 and 1.7 branches (moved merged tags).
            Fixed.

            TODO: get Martin D. to fix Bug MDLSITE-49.

            Show
            nfreear Nick Freear added a comment - I've committed fixes to the 4 header.html on HEAD, 1.8 and 1.7 branches (moved merged tags). Fixed. TODO: get Martin D. to fix Bug MDLSITE-49 .

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Oct/07