[MDL-54007] Restrict unit tests in mod_assign to core plugins - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.9.6, 3.0.4
Fix Version/s: 2.9.6, 3.0.4
Component/s: Assignment
Labels:
- ci
- netspot
- partner
- patch

Affected Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Fixed Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Pull from Repository:
git://github.com/aolley/moodle.git
Pull Master Branch:
~~MDL-54007~~
Pull Master Diff URL:
https://github.com/aolley/moodle/compare/moodle:master...MDL-54007
Testing Instructions:

Hide

Install the following third party plugins:

Submission: https://moodle.org/plugins/assignsubmission_onlineaudio
Feedback: https://moodle.org/plugins/assignfeedback_poodll (requires https://moodle.org/plugins/filter_poodll)

Prior to this fix, you should get unit test failures.
With this fix applied, they should disappear.

Show
Install the following third party plugins: Submission: https://moodle.org/plugins/assignsubmission_onlineaudio Feedback: https://moodle.org/plugins/assignfeedback_poodll (requires https://moodle.org/plugins/filter_poodll ) Prior to this fix, you should get unit test failures. With this fix applied, they should disappear.

Description

The unit test added in ~~MDL-53000~~ makes assumptions about the plugins installed based on a vanilla install, which causes issues when 3rd party assignsubmission or assignfeedback plugins are installed.

The same problem is present in tests added by ~~MDL-52924~~ for M3.1, where it assumes the only submission and feedback plugins returned in an array for a websvc call are core ones.

This is remedied by ensuring we're testing the known plugins where we know what to expect (that is, core plugins, not 3rd party).

Attachments

Issue Links

is a regression caused by

MDL-53000 The assignment subplugin "editpdf" is missing the get_file_areas implementation

Closed

MDL-52924 New Web Service mod_assign_get_submission_status

Closed

Activity

People

Assignee:: Adam Olley

Reporter:: Adam Olley

Peer reviewer:: Eloy Lafuente (stronk7)

Integrator:: Dan Poltawski

Tester:: Dan Poltawski

Participants:: Adam Olley, CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7)

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 02/May/16 8:10 PM

Updated:: 07/May/16 2:51 AM

Resolved:: 07/May/16 2:51 AM

Fix Release Date:: 9/May/16