Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54025

External Tool overwrites activity name when cartridge is used

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites:
      You'll need one course with a teacher enrolled.

      Testing Instructions:
      As an admin user:

      1. Navigate to Site admin > Plugins > Activity modules > LTI / External Tool > Manage tools
      2. Paste https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml into the Tool URL and click 'Add'.
      3. Enter any key and secret and click 'Save changes'
      4. Confirm that you see the new tool added to the page, and that it is named 'Wikipedia'.
      5. Delete the tool.
      1. Navigate to Site admin > Plugins > Activity modules > LTI / External Tool > Manage tools
      2. Click 'Configure a tool manually'
      3. Enter the name 'Test Tool' and paste https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml into the URL field.
      4. Click 'Save'.
      5. Confirm that you see the new tool added to the page and that it is named 'Test Tool'.
      6. Delete the tool.

      Now, as a Teacher:

      1. Log in to the course as a teacher and enable editing.
      2. Click 'Add an activity or resource'.
      3. Select 'External tool' and click 'Add'.
      4. Set activity name to 'My Test Tool' and Launch/Cartridge URL to https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml
      5. Click 'Save and return to course'.
      6. Confirm that you see the tool listed with the name 'My Test Tool' - or whatever you entered when creating the tool.
      1. Navigate to the course page again.
      2. Click 'Add an activity or resource'.
      3. Select 'External tool' and click 'Add'.
      4. Click the plus symbol next to the preconfigured tool select to add a new tool.
      5. Enter the name 'Course Tool Test' and paste https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml into the URL field.
      6. Click 'Save changes'.
      7. Confirm that you see a notification telling you that the tool has been created and that you can see the tool, named 'Course Tool Test' in the preconfigured tool select menu.
      8. Set the activity name to 'Course Tool Test 2' and click 'Save changes'.
      9. Confirm that you see the tool listed with the name 'Course Tool Test 2' - or whatever you entered in the last step

      Finally, behat:

      1. Confirm --tags='@mod_lti' tests are passing
      Show
      Prerequisites: You'll need one course with a teacher enrolled. Testing Instructions: As an admin user: Navigate to Site admin > Plugins > Activity modules > LTI / External Tool > Manage tools Paste https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml into the Tool URL and click 'Add'. Enter any key and secret and click 'Save changes' Confirm that you see the new tool added to the page, and that it is named 'Wikipedia'. Delete the tool. Navigate to Site admin > Plugins > Activity modules > LTI / External Tool > Manage tools Click 'Configure a tool manually' Enter the name 'Test Tool' and paste https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml into the URL field. Click 'Save'. Confirm that you see the new tool added to the page and that it is named 'Test Tool'. Delete the tool. Now, as a Teacher: Log in to the course as a teacher and enable editing. Click 'Add an activity or resource'. Select 'External tool' and click 'Add'. Set activity name to 'My Test Tool' and Launch/Cartridge URL to https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml Click 'Save and return to course'. Confirm that you see the tool listed with the name 'My Test Tool' - or whatever you entered when creating the tool. Navigate to the course page again. Click 'Add an activity or resource'. Select 'External tool' and click 'Add'. Click the plus symbol next to the preconfigured tool select to add a new tool. Enter the name 'Course Tool Test' and paste https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml into the URL field. Click 'Save changes'. Confirm that you see a notification telling you that the tool has been created and that you can see the tool, named 'Course Tool Test' in the preconfigured tool select menu. Set the activity name to 'Course Tool Test 2' and click 'Save changes'. Confirm that you see the tool listed with the name 'Course Tool Test 2' - or whatever you entered in the last step Finally, behat: Confirm --tags='@mod_lti' tests are passing
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54025_master

      Description

      When adding an external tool using the cartridge url (introduced in Moodle 3.1) the activity name is overwritten with the contents of the tool id key found in the cartridge configuration.

      Steps to reproduce: (Can be reproduced on qa.moodle.net)

      1. Create a NEW external tool activity
      2. Set ONLY the following fields:
        1. Activity Name -> TEST ME
        2. Preconfigured tool -> Automatic, based on launch URL
        3. Launch/Cartridge URL -> https://www.eduappcenter.com/configurations/oc8j7hxnzsej9h62.xml
      3. Press "Save And Display"
      4. Navigate back to course

      Expected Result: Activity is named "TEST ME"
      Actual Result: Activity is named "Wikipedia"

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16