Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54036

Remove unused sort variable in forum_print_posts_flat

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.4, 3.1
    • Fix Version/s: 3.2
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      View a discussion page with several replies.
      change the display mode to both flat displays (newest first; oldest first).
      The display should update as expected, without any error or notice message.

      Show
      View a discussion page with several replies. change the display mode to both flat displays (newest first; oldest first). The display should update as expected, without any error or notice message.
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-54036_master

      Description

      The function forum_print_posts_flat has a $sort variable that is determined by the forum mode.
      This is actually implemented in the calling function (forum_print_discussion) and has no use in here.

        Attachments

          Activity

            People

            Assignee:
            l.gil Lior Gil
            Reporter:
            l.gil Lior Gil
            Peer reviewer:
            Frédéric Massart
            Integrator:
            Dan Poltawski
            Tester:
            cameron1729
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              5/Dec/16