Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54055

It is possible to insert blank entries for frequently used comments in marking guide

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.5, 3.0.3, 3.1
    • Fix Version/s: 3.0.5
    • Component/s: Grading methods
    • Labels:
    • Testing Instructions:
      Hide
      Before upgrading
      1. Create an assignment and set this assignment's grading method to Marking guide.
      2. Define the assignment's marking guide.
      3. Enter some criteria.
      4. Under the Frequently used comments section, leave the first comment entry as it is and click Add frequently used comment. This will insert a second row.
      5. Enter AA.
      6. Save the marking guide and make it ready.
      7. Navigate to Assignment administration => Advanced grading and check the Frequently used comments section. Confirm that it has 2 rows. 1 empty and 1 row with the AA comment.
      Upgrade
      1. Upgrade your site with the patch included.
        • Confirm that the upgrade process ends successfully.
      2. Navigate to the assignment, and click Advanced grading under Assignment administration.
      3. Check the Frequently used comments section.
        • Confirm that it now only has a single row with the AA comment.
      4. Edit the assignment's marking guide definition.
      5. Under the Frequently used comments section, click Add frequently used comment to add a new comment entry but do not enter anything.
      6. Click Add frequently used comment again to add another comment entry and enter blank spaces only.
      7. Click Add frequently used comment again to add another comment entry and enter Comment 1.
      8. Save the marking guide.
      9. Navigate to Assignment administration => Advanced
        • Confirm that there is only AA and Comment 1 listed in the Frequently used comments section.
      Show
      Before upgrading Create an assignment and set this assignment's grading method to Marking guide. Define the assignment's marking guide. Enter some criteria. Under the Frequently used comments section, leave the first comment entry as it is and click Add frequently used comment . This will insert a second row. Enter AA . Save the marking guide and make it ready. Navigate to Assignment administration => Advanced grading and check the Frequently used comments section. Confirm that it has 2 rows. 1 empty and 1 row with the AA comment. Upgrade Upgrade your site with the patch included. Confirm that the upgrade process ends successfully. Navigate to the assignment, and click Advanced grading under Assignment administration. Check the Frequently used comments section. Confirm that it now only has a single row with the AA comment. Edit the assignment's marking guide definition. Under the Frequently used comments section, click Add frequently used comment to add a new comment entry but do not enter anything. Click Add frequently used comment again to add another comment entry and enter blank spaces only. Click Add frequently used comment again to add another comment entry and enter Comment 1 . Save the marking guide. Navigate to Assignment administration => Advanced Confirm that there is only AA and Comment 1 listed in the Frequently used comments section.
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-54055-master

      Description

      When defining a marking guide, you can opt not to enter a frequently used comment, but it will still be saved without any value for the description.

      I think that we should only insert a non-empty frequently used comments.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Jul/16