Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54056

Frequently-used comments chooser in marking guide shows up even if there are no entries

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: Grading methods
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an assignment.
      2. Set its grading method to Marking guide.
      3. Define the marking guide, but do not define any item for the frequently used comments.
      4. Save the marking guide and make it ready.
      5. Go back to the assignment and grade it.
      6. On the grading page, check the marking guide section.
        • Confirm that the Insert frequently used comment button is not being rendered below the criterion's comment text area.
        • Confirm that there are no JS errors or warnings in your console
      7. Edit the assignment's marking guide definition and define some comments and save the marking guide definition.
      8. Go back to the assignment's grading page and check the marking guide section.
        • Confirm that the Insert frequently used comment button is being rendered below the criterion's comment text area.
        • Confirm that there are no JS errors or warnings in your console
      9. Click on a criterion's Insert frequently used comment button.
        • Confirm that the Frequently used comments dialogue is being shown.
        • Confirm that the previously defined frequently used comments are listed in the dialogue.
      10. Click on a frequently-used comment.
        • Confirm that the dialogue closes and the selected comment is reflected in the comment text area of the chosen criterion.
      Show
      Create an assignment. Set its grading method to Marking guide. Define the marking guide, but do not define any item for the frequently used comments. Save the marking guide and make it ready. Go back to the assignment and grade it. On the grading page, check the marking guide section. Confirm that the Insert frequently used comment button is not being rendered below the criterion's comment text area. Confirm that there are no JS errors or warnings in your console Edit the assignment's marking guide definition and define some comments and save the marking guide definition. Go back to the assignment's grading page and check the marking guide section. Confirm that the Insert frequently used comment button is being rendered below the criterion's comment text area. Confirm that there are no JS errors or warnings in your console Click on a criterion's Insert frequently used comment button. Confirm that the Frequently used comments dialogue is being shown. Confirm that the previously defined frequently used comments are listed in the dialogue. Click on a frequently-used comment. Confirm that the dialogue closes and the selected comment is reflected in the comment text area of the chosen criterion.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-54056-master

      Description

      There's no point in showing the frequently used comments chooser when there are no defined frequently-used comments in the marking guide.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16