Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54061

Offline Grading Worksheet csv saves as tab separated values, won't upload

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: Assignment, Grading methods
    • Labels:
      None
    • Testing Instructions:
      Hide

      This test requires a course with 3 students enrolled and an assignment set up where online text, file submissions and feedback files have been set to "No" and feedback comments and offline grading worksheet have been set to "yes". All 3 students must be given a grade and feedback.

      1. As a teacher, click on the assignment and navigate to "View all submissions"
      2. From the dropdown box, choose "Download grading worksheet" and save the file.
      3. Navigate back to the assignment grading screen and change one student's grade and feedback comment.
      4. Open the downloaded file in a program such as Excel and add a different grade and feedback comment for that same student. Save as a csv file.
      5. Navigate back to the assignment grading screen and click on "Upload grading worksheet"
      6. If you used microsoft excel to make you changes then select 'Tab' as your separator. Otherwise leave the separator to the default of 'Comma'.
      7. Leave untouched the box "Allow updating records that have been modified more recently etc.."
      8. Verify that the screen "Confirm changes in grading worksheet" displays "no modified grades were found". Cancel the action.
      9. Upload the worksheet again, this time ticking the box "Allow updating records that have been modified more recently etc"
      10. Verify that the screen "Confirm changes" displays the grade and feedback from the csv file ready to update on Moodle. Click Confirm.
      11. Verify that in Moodle's gradebook the student's grade and feedback you changed in #3 have been altered to what you added to the csv file.
      Show
      This test requires a course with 3 students enrolled and an assignment set up where online text, file submissions and feedback files have been set to "No" and feedback comments and offline grading worksheet have been set to "yes". All 3 students must be given a grade and feedback. As a teacher, click on the assignment and navigate to "View all submissions" From the dropdown box, choose "Download grading worksheet" and save the file. Navigate back to the assignment grading screen and change one student's grade and feedback comment. Open the downloaded file in a program such as Excel and add a different grade and feedback comment for that same student. Save as a csv file. Navigate back to the assignment grading screen and click on "Upload grading worksheet" If you used microsoft excel to make you changes then select 'Tab' as your separator. Otherwise leave the separator to the default of 'Comma'. Leave untouched the box "Allow updating records that have been modified more recently etc.." Verify that the screen "Confirm changes in grading worksheet" displays "no modified grades were found". Cancel the action. Upload the worksheet again, this time ticking the box "Allow updating records that have been modified more recently etc" Verify that the screen "Confirm changes" displays the grade and feedback from the csv file ready to update on Moodle. Click Confirm. Verify that in Moodle's gradebook the student's grade and feedback you changed in #3 have been altered to what you added to the csv file.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-54061-master

      Description

      In current 3.1dev, saving an Offline Grading Worksheet from an assignment will download a csv file as expected. Opening this file in Excel, adding grades, and directly saving (via the save option/icon rather than 'save as') will result in the file keeping its csv extension but replacing all the commas with tabs (evident by opening in any text editor after saving).
      csv file without any commas then throws error if user tries to upload the grading worksheet.

      The same results in current builds of 3.0 or earlier are unaffected, so new to 3.1
      Occurs across any Excel versions tried.

      1. Create an assignment (with 'offline grading worksheet' enabled)
      2. Download grading worksheet from top dropdown
      3. Confirm it has the .csv file extension
      4. Open file in Excel. Provide a grade in the Grade column.
      5. Click the Save icon in top left.
      6. Check file in notepad - in 3.1dev, should have become tab separated, despite csv extension
      7. Download another grading worksheet
      8. Open file in Excel. Provide grade.
      9. From the menu, select Save As, pick 'csv'
      10. Check file in notepad, should be comma separated
      11. Repeat steps 1-6 in earlier Moodle versions, should retain commas as expected

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16