Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54101

The get_string function in the core/str amd module handles caching strings with params incorrectly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.0.5
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Make sure your site isn't running in dev mode (e.g. caching should be enabled).
      2. Visit 'Site administration' > 'Development' > 'Template library'.
      3. Click on different template links and ensure the string 'Template: <template name>' changes.
      4. Refresh the page (so JS will start using caches).
      5. Click on different template links and ensure the string 'Template: <template name>' changes.
      Show
      Make sure your site isn't running in dev mode (e.g. caching should be enabled). Visit 'Site administration' > 'Development' > 'Template library'. Click on different template links and ensure the string 'Template: <template name>' changes. Refresh the page (so JS will start using caches). Click on different template links and ensure the string 'Template: <template name>' changes.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54101_master

      Description

      The student count up the top right of the new grading interface (the "1 of 10") underneath the change student navigation isn't updated if you leave the grading interface and then go back in. Instead it just gets set to "0 of 0" and doesn't change.

      Steps to replicate:

      1. Make sure your site isn't running in dev mode (e.g. caching should be enabled)
      2. Create a course with an assignment activity
      3. View the assignment and click "grade" to enter the new grading interface
      4. Notice up the top right it should have a populated student count (e.g. 1 of 10)
      5. Return to the assignment activity
      6. Click "grade" again to take you back into the grader
      7. Notice up the top right it now just shows "0 of 0" where previously it showed the proper count
      8. You can now navigate to any other assignment and grade it and you'll only see "0 of 0" until you purge the caches

      It seems like it has something to do with the caches as this doesn't occur in dev mode (e.g. no caching).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Jul/16