Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54121

tool_lp/dialogue adds content after render breaking moodle-core-lockscroll

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: Competencies
    • Labels:
    • Testing Instructions:
      Hide

      Resize your window very small (850px x 400px or a landscape tablet more or less)
      Open a modal dialogue
      Verify the dialogue opened full screen
      Try and scroll
      Close the dialogue
      Verify the page scroll position was not changed while the dialogue was open
      Make your screen a little wider
      Open a modal dialogue that does not fit vertically in the window (use the competency picker)
      Verify you can scroll up and down to see all of the content of the dialogue
      Close the dialogue
      Check the JS console for errors/warnings
      Make the window bigger so the whole dialogue fits
      Open a the competency picker
      Verify you cannot scroll up and down but can see the whole content of the dialogue
      Close the dialogue
      Check the JS console for errors/warnings

      Nested dialogue check.

      Create a competency framework with a competency, add it to a course.

      View the course competency breakdown report.
      On a TINY window (like 100px high) click on the table cell with a rating to open the rate competency dialogue.
      Verify you can scroll up and down to see the entire dialogue.
      Click on the "Rate" button to open a nested dialogue.
      Verify you can scroll up and down to see the entire nested dialogue.
      Close the nested dialogue.
      Verify you can still scroll up and down to see the entire rating dialogue.
      Close the dialogue.
      Verify you can scroll the page up and down again.

      Show
      Resize your window very small (850px x 400px or a landscape tablet more or less) Open a modal dialogue Verify the dialogue opened full screen Try and scroll Close the dialogue Verify the page scroll position was not changed while the dialogue was open Make your screen a little wider Open a modal dialogue that does not fit vertically in the window (use the competency picker) Verify you can scroll up and down to see all of the content of the dialogue Close the dialogue Check the JS console for errors/warnings Make the window bigger so the whole dialogue fits Open a the competency picker Verify you cannot scroll up and down but can see the whole content of the dialogue Close the dialogue Check the JS console for errors/warnings Nested dialogue check. Create a competency framework with a competency, add it to a course. View the course competency breakdown report. On a TINY window (like 100px high) click on the table cell with a rating to open the rate competency dialogue. Verify you can scroll up and down to see the entire dialogue. Click on the "Rate" button to open a nested dialogue. Verify you can scroll up and down to see the entire nested dialogue. Close the nested dialogue. Verify you can still scroll up and down to see the entire rating dialogue. Close the dialogue. Verify you can scroll the page up and down again.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54121-master

      Description

      It's proving difficult to add competencies to a course using a smaller screen (e.g. my 11" laptop) because the scroll lock is not being correctly applied to the dialogue. e.g. is applied when it should not be.

      This appears to be because the picker is rendered before the content is fetched and the scroll lock is not refreshed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                damyon Damyon Wiese
                Reporter:
                dobedobedoh Andrew Nicols
                Peer reviewer:
                Andrew Nicols
                Integrator:
                David Monllaó
                Tester:
                John Okely
                Participants:
                Component watchers:
                Damyon Wiese, Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Mihail Geshoski, Peter Dias
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16