Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54129

show_in_course checkbox gets ticked when updating a preconfigured tool

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as an admin.
      2. Go to Site administration / ▶︎ Plugins / ▶︎ Activity modules / ▶︎ LTI / ▶︎ Manage tools.
      3. Add a preconfigured tool (using the 'manual' link), leaving the show_in_course checkbox unticked.
      4. Save changes.
      5. Click the preconfigured tool update link.
      6. Expected result: The show_in_course checkbox remains unticked.
      7. Create another tool as admin, this time ticking the checkbox.
      8. Go to a course and click add an activity. Ensure the tool appears as an activity in the activity chooser.
      9. Log in as a teacher and add a preconfigured tool, by creating an external tool type instance and on the edit screen pressing the + button.
      10. Fill in the details for the type and save.

      LTI2 test

      This requires a live site for configuration.

      • ngrok works well - install the latest version of ngrok and run ngrok http 80
      1. Go to Site administration / ▶︎ Plugins / ▶︎ Activity modules / ▶︎ LTI / ▶︎ Manage tools.
      2. put http://lti.tools/test/tp.php in the "Tool URL" area and click "Add".
      3. Select everything in both boxes (Enabled capabilities, Tool services) and then click "Register tool".
      4. When asked the question "Are you sure you would like to activate this tool?" Click "Yes".
      5. Go to a course and click add an activity. Ensure the tool appears as an activity in the activity chooser.
      Show
      Log in as an admin. Go to Site administration / ▶︎ Plugins / ▶︎ Activity modules / ▶︎ LTI / ▶︎ Manage tools. Add a preconfigured tool (using the 'manual' link), leaving the show_in_course checkbox unticked. Save changes. Click the preconfigured tool update link. Expected result: The show_in_course checkbox remains unticked. Create another tool as admin, this time ticking the checkbox. Go to a course and click add an activity. Ensure the tool appears as an activity in the activity chooser. Log in as a teacher and add a preconfigured tool, by creating an external tool type instance and on the edit screen pressing the + button. Fill in the details for the type and save. LTI2 test This requires a live site for configuration. ngrok works well - install the latest version of ngrok and run ngrok http 80 Go to Site administration / ▶︎ Plugins / ▶︎ Activity modules / ▶︎ LTI / ▶︎ Manage tools. put http://lti.tools/test/tp.php in the "Tool URL" area and click "Add". Select everything in both boxes (Enabled capabilities, Tool services) and then click "Register tool". When asked the question "Are you sure you would like to activate this tool?" Click "Yes". Go to a course and click add an activity. Ensure the tool appears as an activity in the activity chooser.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-54129-master

      Description

      Steps to recreate:

      1. Log in as an admin and add a preconfigured tool, leaving the show_in_course checkbox unticked
      2. Save changes
      3. Click the preconfigured tool update link

      Expected result: The show_in_course checkbox remains unticked.

      Actual result: The show_in_course checkbox is now ticked.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16