Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54164

Close buttons on every notification on upgrade/install pages look bad and dont work

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: HTML and CSS
    • Labels:
    • Testing Instructions:
      Hide

      Web interface

      1. Edit your version.php file and increment the version
      2. Log in as admin
      3. Run through the upgrade
      4. Confirm that the success notification doesn't have a close button

      CLI

      1. initialise the phpunit test environment
        • php admin/tool/phpunit/cli/init.php
      2. Confirm that the success notifications are not printed as HTML, instead you should see ++ Success ++
      Show
      Web interface Edit your version.php file and increment the version Log in as admin Run through the upgrade Confirm that the success notification doesn't have a close button CLI initialise the phpunit test environment php admin/tool/phpunit/cli/init.php Confirm that the success notifications are not printed as HTML, instead you should see ++ Success ++
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-54164-master

      Description

      Do an upgrade. Observe hundreds of pointless close buttons that don't do anything when clicked.

      Note: I guess the reason they don't work is because the JS is loaded in the footer which is not sent until minutes after all the notifications are displayed. It's not really a bug.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16