Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54164

Close buttons on every notification on upgrade/install pages look bad and dont work

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 3.1
    • 3.1
    • HTML and CSS
    • MOODLE_31_STABLE
    • MOODLE_31_STABLE
    • MDL-54164-master
    • Hide

      Web interface

      1. Edit your version.php file and increment the version
      2. Log in as admin
      3. Run through the upgrade
      4. Confirm that the success notification doesn't have a close button

      CLI

      1. initialise the phpunit test environment
        • php admin/tool/phpunit/cli/init.php
      2. Confirm that the success notifications are not printed as HTML, instead you should see ++ Success ++
      Show
      Web interface Edit your version.php file and increment the version Log in as admin Run through the upgrade Confirm that the success notification doesn't have a close button CLI initialise the phpunit test environment php admin/tool/phpunit/cli/init.php Confirm that the success notifications are not printed as HTML, instead you should see ++ Success ++

      Do an upgrade. Observe hundreds of pointless close buttons that don't do anything when clicked.

      Note: I guess the reason they don't work is because the JS is loaded in the footer which is not sent until minutes after all the notifications are displayed. It's not really a bug.

            ryanwyllie Ryan Wyllie
            damyon Damyon Wiese
            Damyon Wiese Damyon Wiese
            David Monllaó David Monllaó
            Jake Dallimore Jake Dallimore
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.