Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54165

New grading interface should hide editpdf if unoconv is not enabled

    Details

    • Testing Instructions:
      Hide

      Please test on multiple browsers.

      Note: This test requires your server to be set up with ghostscript so that the grading interface works. If you haven't set it up yet then do Test 2 before setting it up and then complete Test 1 after it's set up.

      Test 1

      1. Create a course some students and an assignment
      2. Log in as a teacher / admin and grade the assignment
        • go to the course > assignments > click grade button
      3. Notice three buttons down the bottom right of the grading interface
      4. Click each of the buttons and confirm that the interface hides the appropriate panels, as per the icons on the buttons.
        • Pressing enter or space on a button with focus should also activate the button
      5. Confirm that you can't tab into a hidden panel
      6. Confirm that you can't navigate into a hidden panel using a screen reader
      7. Narrow the screen to less than 767px wide
      8. Confirm that the review panel has a collapse/expand button up the top left and clicking it collapses/expands the panel.
      9. Change the language to an RTL language
      10. Confirm that the collapse/expand button on the narrow view changes to the top right hand side of the panel.
      11. Confirm that on a full width page in RTL that the layout buttons remain in the same order as they did for LTR (because the layout of the grading interface doesn't change).

      Test 2

      1. Either run this test on a server that doesn't have ghostscript installed / configured or you can edit mod/assign/classes/output/grading_app.php and set $export->showreview = false; around line 124 (after the plugin loop) to simulate the situation.
      2. Load up the grading interface from Test 1
      3. Confirm that no review panel is shown
      4. Confirm that no layout buttons are shown on the bottom right of the page
      Show
      Please test on multiple browsers. Note: This test requires your server to be set up with ghostscript so that the grading interface works. If you haven't set it up yet then do Test 2 before setting it up and then complete Test 1 after it's set up. Test 1 Create a course some students and an assignment Log in as a teacher / admin and grade the assignment go to the course > assignments > click grade button Notice three buttons down the bottom right of the grading interface Click each of the buttons and confirm that the interface hides the appropriate panels, as per the icons on the buttons. Pressing enter or space on a button with focus should also activate the button Confirm that you can't tab into a hidden panel Confirm that you can't navigate into a hidden panel using a screen reader Narrow the screen to less than 767px wide Confirm that the review panel has a collapse/expand button up the top left and clicking it collapses/expands the panel. Change the language to an RTL language Confirm that the collapse/expand button on the narrow view changes to the top right hand side of the panel. Confirm that on a full width page in RTL that the layout buttons remain in the same order as they did for LTR (because the layout of the grading interface doesn't change). Test 2 Either run this test on a server that doesn't have ghostscript installed / configured or you can edit mod/assign/classes/output/grading_app.php and set $export->showreview = false; around line 124 (after the plugin loop) to simulate the situation. Load up the grading interface from Test 1 Confirm that no review panel is shown Confirm that no layout buttons are shown on the bottom right of the page
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull 3.1 Branch:
    • Pull Master Branch:
      MDL-54165-master

      Description

      Currently this feature requires unoconv 0.7 to work, however most distros are still pointing to 0.6. So, it is not entirely easy to set this feature up. Even after downloading the unoconv file from https://github.com/dagwieers/unoconv I received the error 'unoconv: Cannot find a suitable office installation on your system. ERROR: Please locate your office installation and send your feedback to: http://github.com/dagwieers/unoconv/issues' when trying to run it - which means it requires even further tweaking. I think it is safe to assume that a large majority of sites will not have this feature enabled (at least for some time). So, when teachers view this area for marking they will see a huge dominant white area that serves no use unless they are marking a PDF and will cause a lot of confusion. We should solve this now. Currently if you do not have GS on your site the editpdf is not shown. We should do the same for unoconv if the files being marked are not PDFs.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  27 Vote for this issue
                  Watchers:
                  35 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Jul/16