Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54540

Add allowfullscreen attribute to LTI IFrames

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Add "https://www.edu-apps.org/lti_public_resources/config.xml?id=youtube" to Site administration > Plugins > Activity modules > External tool > Manage tools (no key or secret)
      2. Add an instance of External tool to your course, setting the type to the one you just added
      3. Save and display
      4. Search for a video, and play it
        1. Make sure you can press fullscreen on the video and it successfully fills the screen
      Show
      Add "https://www.edu-apps.org/lti_public_resources/config.xml?id=youtube" to Site administration > Plugins > Activity modules > External tool > Manage tools (no key or secret) Add an instance of External tool to your course, setting the type to the one you just added Save and display Search for a video, and play it Make sure you can press fullscreen on the video and it successfully fills the screen
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      master

      Description

      Suggestion

      This would allow external Tools to be displayed in fullscreen. This can be crucial for some mobile applications.

      Pull 3.2 Branch: MOODLE_32_STABLE
      Pull 3.2 Diff URL: https://github.com/moodle/moodle/compare/MOODLE_32_STABLE...ConnorSheremeta:MOODLE_32_STABLE
      Pull 3.3 Branch: MOODLE_33_STABLE
      Pull 3.3 Diff URL: https://github.com/moodle/moodle/compare/MOODLE_33_STABLE...ConnorSheremeta:MOODLE_33_STABLE

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ConnorSheremeta Connor Sheremeta
              Reporter:
              capira Robin Woll
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Andrew Lyons Andrew Lyons
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              5 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Nov/17