[MDL-54560] Search menu item is 4 pixels too tall - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Enable global search (you should be able to just enable it, without configuring it).

Confirm that the navbar is 40px tall (41 including the bottom border).

Confirm that the search hide/reveal works correctly.

This should be done in various browsers, and in a RTL language.

Note: If ~~MDL-54559~~ has not been integrated, the bar will be 42px tall because of a similar problem. You can add the patch from that and re-grunt to confirm the behavior.
Show
Enable global search (you should be able to just enable it, without configuring it). Confirm that the navbar is 40px tall (41 including the bottom border). Confirm that the search hide/reveal works correctly. This should be done in various browsers, and in a RTL language. Note: If MDL-54559 has not been integrated, the bar will be 42px tall because of a similar problem. You can add the patch from that and re-grunt to confirm the behavior.
Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
git://github.com/dmonllao/moodle.git
Pull Master Branch:
~~MDL-54560~~_master
Pull Master Diff URL:
https://github.com/dmonllao/moodle/compare/MDL-54560_master~2...MDL-54560_master

The search menu item, due to padding and such, is 4 pixels too tall, and pushes the bottom of the bar down.

has been marked as being related by

MDL-54559 Usermenu margin expands navbar

is a regression caused by

MDL-31989 Global Search 2

Participants:: Andrew Lyons, CiBoT, Dan Poltawski, David Monllaó, Eric Merrill, Frédéric Massart, Jun Pataleta

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Huong Nguyen, Bas Brands, Mathew May