Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54563

It should not be possible to add the course completion blocks to the front page

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.4
    • Fix Version/s: 3.2
    • Component/s: Blocks, Course completion
    • Labels:
    • Testing Instructions:
      Hide

      Before Applying the patch:

      1. Add the course completion status block to the front page
      2. Add the self completion block to the front page
        Apply the patch
      3. Visit the front page and verify there aren't any errors
      4. Remove the course completion block from the frontpage
      5. Remove the self completion block from the front page
      6. Verify that you cannot re-add either block to the front page
      7. Navigate to a course
      8. Verify you can add the course completion and self completion blocks to the course page
      9. Run the behat tests from MDL-54130
      Show
      Before Applying the patch: Add the course completion status block to the front page Add the self completion block to the front page Apply the patch Visit the front page and verify there aren't any errors Remove the course completion block from the frontpage Remove the self completion block from the front page Verify that you cannot re-add either block to the front page Navigate to a course Verify you can add the course completion and self completion blocks to the course page Run the behat tests from MDL-54130
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-54563-master

      Description

      While working on MDL-54130 I found that it was possible to add both the course completion and self completion blocks to the site frontpage. When added in this fashion, the blocks display "Completion is not enabled for this course" which suggests that it is possible to configure course completion in this context. (If you force the block to display on all pages on the site, you get this message on every page that is not part of a course)

      Since it is not possible to configure course completion on the front page or any context that is not a course, these blocks to should be limited to course pages only.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sbourget Stephen Bourget
              Reporter:
              sbourget Stephen Bourget
              Peer reviewer:
              cameron1729
              Integrator:
              Dan Poltawski
              Tester:
              Jake Dallimore
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16