Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54567

process_gradebook is not being run when restoring a course.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.4, 3.1
    • Fix Version/s: 3.0.5, 3.1.1
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide

      Pre-requisites

      1. For each of those Moodle versions:
        • 2.8 (latest)
        • 2.9 (latest)
        • 3.0 prior to this patch (latest release)
        • 3.0 including this patch (integration repo)
        • 3.1 prior to this patch (latest release)
        • 3.1 including this patch (integration repo)
      2. Create a fresh new course
      3. Change the default Letters for that course specifically
        • Dashboard ► Courses ► Course A ► Grade administration ► Letters
      4. In your database, create the following entry in mdl_config
        • name: gradebook_calculations_freeze_COURSEID (replace COURSEID with the new course's ID)
        • value: 12345
      5. Purge caches
      6. Visit the gradebook of the course and confirm that a warning message indicates that you're not using the latest gradebook version
      7. Backup the course with default settings, and save the file somewhere

      Restore test

      1. Grab each backup file and restore it as a new course
      2. Head to the gradebook of the newly restored course and confirm that the same warning message as before is displayed.
      3. Optionally confirm that there is an entry in mdl_config for gradebook_calculations_freeze_COURSEID and that its value is 12345
      Show
      Pre-requisites For each of those Moodle versions: 2.8 (latest) 2.9 (latest) 3.0 prior to this patch (latest release) 3.0 including this patch (integration repo) 3.1 prior to this patch (latest release) 3.1 including this patch (integration repo) Create a fresh new course Change the default Letters for that course specifically Dashboard ► Courses ► Course A ► Grade administration ► Letters In your database, create the following entry in mdl_config name: gradebook_calculations_freeze_COURSEID (replace COURSEID with the new course's ID) value: 12345 Purge caches Visit the gradebook of the course and confirm that a warning message indicates that you're not using the latest gradebook version Backup the course with default settings, and save the file somewhere Restore test Grab each backup file and restore it as a new course Head to the gradebook of the newly restored course and confirm that the same warning message as before is displayed. Optionally confirm that there is an entry in mdl_config for gradebook_calculations_freeze_COURSEID and that its value is 12345
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54567-master-build
    • Pull Master Diff URL:
    • Sprint:
      3.2 Sprint 1

      Description

      When restoring a course the method process_gradebook() in backup/moodle2/restore_stepslib.php is not run. This means that the gradebook calculations freeze is not being adhered to properly when restoring a course.

      Easy way to replicate -

      1. edit restore_stepslib.php and put a die() in process_gradebook.
      2. restore a course.
      3. Notice that the restore never dies.

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45390 Problem: Cannot get 57% to return the required letter grade

          • Major - Major loss of function, incorrect output
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-54732 Reconsider the current warning when restoring backups into older sites

          • Minor - Minor loss of function where workaround is possible
          • Open
          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-49257 Adjusting weights when extra credit item is present causes unexpected behavior

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              David Monllaó David Monllaó
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Ryan Wyllie Ryan Wyllie
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/16