Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54593

tool_lp alerts missing a bootstrap class

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1
    • Component/s: Competencies
    • Labels:
    • Testing Instructions:
      Hide

      Test on a site that has not set up any competency data

      1. Visit a course.
      2. Visit 'Course administration' > 'Competencies'.
      3. Check the 'No competencies have been linked to this course.' message appears in a box styled the same as the one in the 'after.png' screenshot attached, not the 'before.png'.
      4. Visit 'Site administration' > 'Competencies' > 'Competency frameworks'.
      5. Check the 'No competency frameworks have been created yet.' message appears in a box styled ....
      6. Visit 'Site administration' > 'Competencies' > 'Learning plan templates'.
      7. Check the 'No learning plan templates have been created yet.' message appears in a box styled ....
      8. Add a new learning plan.
      9. Check the 'No competencies have been linked to this learning plan template.' message appears in a box styled ....
      10. Visit your profile.
      11. Click on 'Learning plans' under 'Miscellaneous'.
      12. Check the 'No learning plans have been created yet.' message appears in a box styled ....
      13. Click on 'Evidence of prior learning'.
      14. Check the 'No evidence of prior learning has been added yet.' message appears in a box styled ....
      Show
      Test on a site that has not set up any competency data Visit a course. Visit 'Course administration' > 'Competencies'. Check the 'No competencies have been linked to this course.' message appears in a box styled the same as the one in the 'after.png' screenshot attached, not the 'before.png'. Visit 'Site administration' > 'Competencies' > 'Competency frameworks'. Check the 'No competency frameworks have been created yet.' message appears in a box styled .... Visit 'Site administration' > 'Competencies' > 'Learning plan templates'. Check the 'No learning plan templates have been created yet.' message appears in a box styled .... Add a new learning plan. Check the 'No competencies have been linked to this learning plan template.' message appears in a box styled .... Visit your profile. Click on 'Learning plans' under 'Miscellaneous'. Check the 'No learning plans have been created yet.' message appears in a box styled .... Click on 'Evidence of prior learning'. Check the 'No evidence of prior learning has been added yet.' message appears in a box styled ....
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54593_master

      Description

      According to https://getbootstrap.com/2.3.2/components.html#alerts, alerts should also have the alert class.

      I've noticed a couple of places where it's missing:

      course_competencies_page.mustache:<p class="alert-info">
      manage_competency_frameworks_page.mustache:<p class="alert-info">
      manage_templates_page.mustache:<p class="alert-info">
      no_frameworks_warning.mustache:<p class="alert-error">
      plans_page.mustache:<p class="alert-info">
      template_competencies_page.mustache:        <p class="alert-info">
      user_evidence_list_page.mustache:    <p class="alert-info">{{#str}}nouserevidence, tool_lp{{/str}}</p>
      

        Attachments

        1. after.png
          after.png
          19 kB
        2. before.png
          before.png
          18 kB

          Activity

            People

            • Assignee:
              markn Mark Nelson
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Jake Dallimore
              Integrator:
              Dan Poltawski
              Tester:
              cameron1729
              Participants:
              Component watchers:
              Damyon Wiese, Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Mihail Geshoski, Peter Dias
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                23/May/16