Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54605

Quiz regrade attempts needing it causes Incorrect number of query parameters error with groups.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.6, 3.0.4
    • Fix Version/s: 3.0.5, 3.1.1
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. You need a course with two groups, G1 containing Student S1, and G2 containing S2.
      2. As admin/teacher, create a quiz set to separate groups mode.
      3. Add two true-false question, set the right answer to True.
      4. Twice, once as S1 and once as S2, attempt the quiz.
      5. As admin/teacher, edit both questions, and change the right answer to False.
      6. Go to Quiz administration -> Results -> Grades.
      7. Select group G1.
      8. Click "Dry run a full regrade for group 'Odd group'".
      9. Click"Regrade attempts (1) marked as needing regrading in group 'Odd group'"
      10. Verify that S1's attempt is regraded.
      11. Verify that there were no DB errors.
      12. Verify that there were no developer debug notices about making the first column unique for get_records.

      Note, there will probably be a developer debug notice about doing output before redirecting. Given the way we want to display a progress bar, I think that is unavoidable. (If you have a good idea how to fix that, please open a new MDL. Thanks.)

      Show
      You need a course with two groups, G1 containing Student S1, and G2 containing S2. As admin/teacher, create a quiz set to separate groups mode. Add two true-false question, set the right answer to True. Twice, once as S1 and once as S2, attempt the quiz. As admin/teacher, edit both questions, and change the right answer to False. Go to Quiz administration -> Results -> Grades. Select group G1. Click "Dry run a full regrade for group 'Odd group'". Click"Regrade attempts (1) marked as needing regrading in group 'Odd group'" Verify that S1's attempt is regraded. Verify that there were no DB errors. Verify that there were no developer debug notices about making the first column unique for get_records. Note, there will probably be a developer debug notice about doing output before redirecting. Given the way we want to display a progress bar, I think that is unavoidable. (If you have a good idea how to fix that, please open a new MDL. Thanks.)
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Steps to reproduce:

      1. You need a course with two gropus, G1 containing Student S1, and G2 containing S2.
      2. As admin/teacher, create a quiz set to separate groups mode.
      3. Add one true-false question, set the right answer to True.
      4. Twice, once as S1 and once as S2, attempt the quiz.
      5. As admin/teacher, edit the question, and change the right answer to False.
      6. Go to Quiz administration -> Results -> Grades.
      7. Select group G1.
      8. Click 'Dry run a full regrade'.
      9. Click 'Regrade all attempts needing it'.

      Expected result: S1's attempt is regraded.

      Actual result:
      ERROR: Incorrect number of query parameters. Expected 2, got 1.

      There is also a 'did you remember to make the first column unique' error that can occur.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Frédéric Massart
              Integrator:
              David Monllaó
              Tester:
              Jun Pataleta
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/16