Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54622

The "Display name" setting in the myprofile block is unused and should be removed

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.4
    • Fix Version/s: 3.2
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide

      Before applying patch.
      1. Add the myprofile (logged in user) block to the dashboard page.
      2. Configure the block to show the username (By default it is set to no)
      3. Apply the patch
      4. View the dashboard page and verify that no errors are shown
      5. Run the behat tests from MDL-54578

      Show
      Before applying patch. 1. Add the myprofile (logged in user) block to the dashboard page. 2. Configure the block to show the username (By default it is set to no) 3. Apply the patch 4. View the dashboard page and verify that no errors are shown 5. Run the behat tests from MDL-54578
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-54622_m32v1

      Description

      Found while testing MDL-54578 the myprofile block has a setting to restrict the display of the currently logged in users name. Since the username is always displayed and this setting has been broken since Moodle 2.0 should probably be removed.

      See:
      https://github.com/moodle/moodle/commit/03d9401e7d581f2aac097f2ad2f2f7d070481afc#diff-c5f931480b5c8002ee0f258298d14227R89

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sbourget Stephen Bourget
              Reporter:
              sbourget Stephen Bourget
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Dan Poltawski
              Tester:
              cameron1729
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16