Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54629

external_format_text should not require the filearea, and itemid if the context does not support them

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1, 3.2
    • Fix Version/s: 3.2
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      I don't really know how these type of changes are tested, I'd suggest the following that will test that are no regressions and the correct usage of external_format_text:

      1. In the moodle site create a new site event for the next week, include in the description of the event an image
      2. Open the site using the Mobile app, go to the Calendar events section and check that the image is correctly displayed in the event
      Show
      I don't really know how these type of changes are tested, I'd suggest the following that will test that are no regressions and the correct usage of external_format_text: In the moodle site create a new site event for the next week, include in the description of the event an image Open the site using the Mobile app, go to the Calendar events section and check that the image is correctly displayed in the event
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54629-master

      Description

      Suggested by Andrew Nicols in MDL-54049, we should make those parameters optional

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jleyva Juan Leyva
              Reporter:
              jleyva Juan Leyva
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16