Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54645

Remove hack for replacing escaped ampersand characters in navigation node title

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.0.4, 3.1
    • Fix Version/s: None
    • Component/s: Blocks, Navigation
    • Labels:
    • Testing Instructions:
      Hide
      Setup
      1. Login as admin.
      2. Create a course and add the special characters & ' " ¢ £ © € ¥ ® < > to the Course full name.
      3. Enrol a student to that course
      4. Login as a student.
      Course node loaded on page load
      1. Hover over the course's link under My courses. Check the title text being displayed.
        • Confirm that the title is rendered properly and that there are no escaped characters. (i.e. &amp;, &gt;, &lt;)
      AJAX testing
      1. Click Site home on the navigation block.
      2. Expand the My courses node.
      3. Hover over the course's link. Check the title text being displayed.
        • Confirm that the title is rendered properly and that there are no escaped characters. (i.e. &amp;, &gt;, &lt;)
      Show
      Setup Login as admin. Create a course and add the special characters & ' " ¢ £ © € ¥ ® < > to the Course full name. Enrol a student to that course Login as a student. Course node loaded on page load Hover over the course's link under My courses . Check the title text being displayed. Confirm that the title is rendered properly and that there are no escaped characters. (i.e. &amp;, &gt;, &lt; ) AJAX testing Click Site home on the navigation block. Expand the My courses node. Hover over the course's link. Check the title text being displayed. Confirm that the title is rendered properly and that there are no escaped characters. (i.e. &amp;, &gt;, &lt; )
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54645-master
    • Pull Master Diff URL:
    • Sprint:
      3.2 Sprint 2

      Description

      To replicate:

      1. Create a course that has a full name which contains < and >.
      2. Check the title of the course's link in the navigation block.
      3. Expecetd:
        • It displays < and >.
      4. Actual:
        • It displays &lt; and &gt; instead.

      Updated description:
      The issue about the escaping of special characters are being dealt with on MDL-47371. This issue has now become just about the removal for the hack that replaces &amp; characters to & in the course navigation node title.

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-54609 Course short names in Courses node of the nav block are being escaped

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-47371 The character & is displayed as " & amp ; " in html tag attributes (for example "title" or "alt") - both format_string() and s() encode it

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              jpataleta Jun Pataleta
              Peer reviewer:
              Mark Nelson
              Integrator:
              Andrew Nicols
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: