Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54649

Fix css lint issues in questions and quiz

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Questions, Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. Add a quiz to a course
      2. Add a calculated, calculated simple, numerical and shortanswer question (click the help button next to the question or read docs if you are not familiar with how to construct the questions)
      3. Preview the questions
      4. VERIFY: the answer boxes for each question looks the same before and after the patch

      On the question edit page..

      1. Add quiz question with really long words in the question name and verify on the question edit page the question title text looks the same before and after the patch

      Verify important removals:

      1. Attempt the quiz as a student
      2. Log in as teacher and go to the results report
      3. VERIFY: that the student icon is horizontaly centred on core themes in the results table (same as before the patch)
      4. Go to the results statistics report
      5. VERIFY: in the Quiz structure analysis table, the columns like 'Attempts, Random guess score are horrizontally centred (same as before the patch) - especially on the question with a long question name

      Run csslint on quiz and questions and ensure its now lint free:
      $ csslint --format=compact mod/quiz/ question/

      Show
      Add a quiz to a course Add a calculated, calculated simple, numerical and shortanswer question (click the help button next to the question or read docs if you are not familiar with how to construct the questions) Preview the questions VERIFY: the answer boxes for each question looks the same before and after the patch On the question edit page.. Add quiz question with really long words in the question name and verify on the question edit page the question title text looks the same before and after the patch Verify important removals: Attempt the quiz as a student Log in as teacher and go to the results report VERIFY: that the student icon is horizontaly centred on core themes in the results table (same as before the patch) Go to the results statistics report VERIFY: in the Quiz structure analysis table, the columns like 'Attempts, Random guess score are horrizontally centred (same as before the patch) - especially on the question with a long question name Run csslint on quiz and questions and ensure its now lint free: $ csslint --format=compact mod/quiz/ question/
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-54649-master

      Description

      csslint --format=compact --quiet mod/quiz/ question/
      /Users/danp/moodles/pm/moodle/mod/quiz/styles.css: line 128, col 5, Warning - vertical-align can't be used with display: block.
      /Users/danp/moodles/pm/moodle/mod/quiz/styles.css: line 429, col 9, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/mod/quiz/styles.css: line 504, col 5, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/mod/quiz/styles.css: line 533, col 5, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/mod/quiz/styles.css: line 850, col 5, Warning - Expected (normal | keep-all | break-all) but found 'break-word'.
       
      /Users/danp/moodles/pm/moodle/question/type/calculated/styles.css: line 3, col 5, Warning - width can't be used with display: inline.
       
      /Users/danp/moodles/pm/moodle/question/type/calculatedsimple/styles.css: line 3, col 5, Warning - width can't be used with display: inline.
       
      /Users/danp/moodles/pm/moodle/question/type/numerical/styles.css: line 3, col 5, Warning - width can't be used with display: inline.
       
      /Users/danp/moodles/pm/moodle/question/type/shortanswer/styles.css: line 3, col 5, Warning - width can't be used with display: inline.
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                poltawski Dan Poltawski
                Reporter:
                poltawski Dan Poltawski
                Peer reviewer:
                Tim Hunt
                Integrator:
                Andrew Nicols
                Tester:
                Simey Lameze
                Participants:
                Component watchers:
                Tim Hunt, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze, Tim Hunt, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16