Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Ensure editpdf is setup (ghoestscript etc)
      2. Setup a file upload assignment
      3. As student, upload a pdf
      4. As teacher go to the grading page, switch to a rtl language and you should get the the editpdf screen
      5. Add a comment to the document
      6. VERIFY: the little menu icon on the comment is the same before and after the patch
      1. Add a choice to a course
      2. In the resutls section of settings choose 'always show results to students' and 'publish anonymous results, do not show student names'
      3. Go to the choice page - look at the responses tablee
      4. VERIFY: The responses table looks the same before and after the patch (no border)
      5. Login as student and submit a choice response
      6. Login as teacher and go to the responses report
      7. VERIFY: the download buttons look the same before and after the patch.
      1. Add a database activity to a course
      2. 'choose a predefined set to get started.'
      3. Select 'image gallery' from use a preset
      1. Add a SCORM module to the course keeping all default settings except for "Appearance" => "Display package" set to New window
      2. Disable JS in your browser
      3. Open the SCORM module
      4. VERIFY: there is no border around the scorm iframe

      Run csslint --quiet --format=compact mod/ and verify no issues

      Show
      Ensure editpdf is setup (ghoestscript etc) Setup a file upload assignment As student, upload a pdf As teacher go to the grading page, switch to a rtl language and you should get the the editpdf screen Add a comment to the document VERIFY: the little menu icon on the comment is the same before and after the patch Add a choice to a course In the resutls section of settings choose 'always show results to students' and 'publish anonymous results, do not show student names' Go to the choice page - look at the responses tablee VERIFY: The responses table looks the same before and after the patch (no border) Login as student and submit a choice response Login as teacher and go to the responses report VERIFY: the download buttons look the same before and after the patch. Add a database activity to a course 'choose a predefined set to get started.' Select 'image gallery' from use a preset Add a SCORM module to the course keeping all default settings except for "Appearance" => "Display package" set to New window Disable JS in your browser Open the SCORM module VERIFY: there is no border around the scorm iframe Run csslint --quiet --format=compact mod/ and verify no issues
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-54654-master

      Description

      /Users/danp/moodles/pm/moodle/mod/assign/feedback/editpdf/styles.css: line 282, col 5, Warning - Expected (<margin-width> | inherit) but found 'none'.
       
      /Users/danp/moodles/pm/moodle/mod/book/tool/print/print.css: line 180, col 9, Warning - Use of !important
       
      /Users/danp/moodles/pm/moodle/mod/choice/styles.css: line 26, col 48, Warning - Expected end of value but found 'inherit'.
      /Users/danp/moodles/pm/moodle/mod/choice/styles.css: line 44, col 97, Warning - display:inline has no effect on floated elements (but may be used to fix the IE6 double-margin bug).
       
      /Users/danp/moodles/pm/moodle/mod/data/preset/imagegallery/csstemplate.css: line 25, col 3, Warning - width can't be used with display: inline.
      /Users/danp/moodles/pm/moodle/mod/data/preset/imagegallery/csstemplate.css: line 26, col 3, Warning - height can't be used with display: inline.
       
      /Users/danp/moodles/pm/moodle/mod/forum/styles.css: line 90, col 1, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/mod/scorm/styles.css: line 88, col 5, Warning - Unknown property 'frameborder'.
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/16