Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54666

Unable to update a forum activity due to scale type change

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 3.1
    • 3.1
    • Gradebook
    • MOODLE_31_STABLE
    • MOODLE_31_STABLE
    • wip-MDL-54666-master
    • Hide

      Prerequisites:

      • Create a scale ABCDEF or anything else is ok.
      • Course with some students enrolled.

      Non-rating activity:

      • Create an assignment and set its grading options to use that ABCDEF scale.
      • Go to the assignment grading interface and grade a student.
      • Edit the assignment settings. Go to the "Grade" fieldset.
      • TEST: Verify the "Some grades have already been awarded..." message is shown.
      • TEST: Verify both the grade type and scale are disabled and with value "scale" and "ABCDEF" respectively.
      • Save the settings.
      • Edit the assignment settings again.
      • TEST: Verify both the grade type and scale are disabled and with value "scale" and "ABCDEF" respectively.

      Rating activity:

      • Create a forum and set its grading options to use that ABCDEF scale.
      • Log in as student and create some discussion/post.
      • Back as teacher (or admin), rate that post.
      • Edit the forum settings. Go to the "Rating" fieldset.
      • TEST: Verify the "Some grades have already been awarded..." message is shown.
      • TEST: Verify the "When selecting a ratings aggregate type you must also select..." message is NOT shown.
      • TEST: Verify both the rating type and scale are disabled and with value "scale" and "ABCDEF" respectively.
      • Save the settings.
      • TEST: Verify the "When selecting a ratings aggregate type you must also select..." message is NOT shown. And the form is saved ok.
      • Edit the forum settings again. Go to the "Rating" fieldset.
      • TEST: Verify both the rating type and scale are disabled and with value "scale" and "ABCDEF" respectively.

      Alternatively:

      • run the lib/form/tests/behat/modgrade_validation.feature feature. It covers exactly the steps above.
      Show
      Prerequisites: Create a scale ABCDEF or anything else is ok. Course with some students enrolled. Non-rating activity: Create an assignment and set its grading options to use that ABCDEF scale. Go to the assignment grading interface and grade a student. Edit the assignment settings. Go to the "Grade" fieldset. TEST: Verify the "Some grades have already been awarded..." message is shown. TEST: Verify both the grade type and scale are disabled and with value "scale" and "ABCDEF" respectively. Save the settings. Edit the assignment settings again. TEST: Verify both the grade type and scale are disabled and with value "scale" and "ABCDEF" respectively. Rating activity: Create a forum and set its grading options to use that ABCDEF scale. Log in as student and create some discussion/post. Back as teacher (or admin), rate that post. Edit the forum settings. Go to the "Rating" fieldset. TEST: Verify the "Some grades have already been awarded..." message is shown. TEST: Verify the "When selecting a ratings aggregate type you must also select..." message is NOT shown. TEST: Verify both the rating type and scale are disabled and with value "scale" and "ABCDEF" respectively. Save the settings. TEST: Verify the "When selecting a ratings aggregate type you must also select..." message is NOT shown. And the form is saved ok. Edit the forum settings again. Go to the "Rating" fieldset. TEST: Verify both the rating type and scale are disabled and with value "scale" and "ABCDEF" respectively. Alternatively: run the lib/form/tests/behat/modgrade_validation.feature feature. It covers exactly the steps above.

    Description

      Since upgrading moodle.org to 3.1.0-rc1, when I try to update a forum activity (say to change the description field) which has ratings with scale type set to 'Scale', when I click the 'Save and display' button, I find that the scale type has been changed to 'Point'. I am not allowed to save the form nor change the scale type. The following messages are displayed:

      'When selecting a ratings aggregate type you must also select to use either a scale or set a maximum points.'

      'Some grades have already been awarded, so the grade type and scale cannot be changed.'

      Attachments

        Issue Links

          Activity

            People

              marina Marina Glancy
              tsala Helen Foster
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                23/May/16