Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54671

Fix final csslint issues in theme/ etc

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      All tests in base theme

      1. Disable all text editor plugins but plain html area
      2. Go to admin > settings frontpage
      3. VERIFY: the front page summary field looks the same before and after the the patch
      1. Add a tag to a course module item
      2. The selected tag should look the same before and after the patch
      1. Go to my private files
      2. Switch to rtl language
      3. Open the file picker, click on server files
      4. VERIFY: the path bar looks the same before and after the patch
      1. Go to atto
      2. Compare the buttons before and after the patch - ensure they look the same

      Run {{ csslint --quiet --format=compact .}} - no lint errors should be present in entire codebase

      Show
      All tests in base theme Disable all text editor plugins but plain html area Go to admin > settings frontpage VERIFY: the front page summary field looks the same before and after the the patch Add a tag to a course module item The selected tag should look the same before and after the patch Go to my private files Switch to rtl language Open the file picker, click on server files VERIFY: the path bar looks the same before and after the patch Go to atto Compare the buttons before and after the patch - ensure they look the same Run {{ csslint --quiet --format=compact .}} - no lint errors should be present in entire codebase
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-54671-master

      Description

      sslint --quiet --format=compact theme/
      /Users/danp/moodles/pm/moodle/theme/base/style/admin.css: line 227, col 57, Warning - width can't be used with display: inline.
       
      /Users/danp/moodles/pm/moodle/theme/base/style/autocomplete.css: line 15, col 5, Error - Duplicate property 'color' found.
       
      /Users/danp/moodles/pm/moodle/theme/base/style/calendar.css: line 18, col 1, Warning - Rule is empty.
       
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 189, col 61, Warning - margin can't be used with display: inline.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 212, col 1, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 215, col 1, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 806, col 1, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1044, col 5, Warning - Expected (visible | hidden | collapse | inherit) but found 'invisible'.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1114, col 78, Warning - width can't be used with display: inline.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1114, col 89, Warning - margin can't be used with display: inline.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1155, col 1, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1422, col 5, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1432, col 5, Warning - margin can't be used with display: inline.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1444, col 5, Warning - float can't be used with display: inline-block.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1774, col 1, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1886, col 23, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1886, col 177, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 1988, col 5, Warning - Expected (<margin-width> | inherit) but found 'initial'.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 2002, col 5, Warning - Expected (<margin-width> | inherit) but found 'initial'.
      /Users/danp/moodles/pm/moodle/theme/base/style/core.css: line 2309, col 5, Warning - Expected (<border-width> || <border-style> || <color>) but found 'inherit'.
       
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 67, col 5, Warning - Expected (<padding-width> | inherit) but found 'auto'.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 112, col 5, Warning - Expected (<padding-width> | inherit) but found 'initial'.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 139, col 5, Warning - Expected (<padding-width> | inherit) but found 'initial'.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 316, col 141, Warning - Expected end of value but found 'left'.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 317, col 125, Warning - Expected end of value but found 'right'.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 378, col 5, Warning - Expected (<padding-width> | inherit) but found 'initial'.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 381, col 5, Warning - Expected (<padding-width> | inherit) but found 'initial'.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 389, col 112, Warning - float can't be used with display: inline-block.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 408, col 1, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 464, col 80, Warning - Expected (inline | block | list-item | inline-block | table | inline-table | table-row-group | table-header-group | table-footer-group | table-row | table-column-group | table-column | table-cell | table-caption | grid | inline-grid | none | inherit | -moz-box | -moz-inline-block | -moz-inline-box | -moz-inline-grid | -moz-inline-stack | -moz-inline-table | -moz-grid | -moz-grid-group | -moz-grid-line | -moz-groupbox | -moz-deck | -moz-popup | -moz-stack | -moz-marker | -webkit-box | -webkit-inline-box | -ms-flexbox | -ms-inline-flexbox | flex | -webkit-flex | inline-flex | -webkit-inline-flex) but found 'initial'.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 466, col 66, Warning - Expected (auto | use-script | baseline | sub | super | top | text-top | central | middle | bottom | text-bottom | <percentage> | <length>) but found 'inherit'.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 544, col 58, Warning - float can't be used with display: inline-block.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 602, col 14, Error - Duplicate property '*display' found.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 669, col 5, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 670, col 5, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 671, col 5, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 685, col 5, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 687, col 5, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 692, col 5, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/base/style/course.css: line 694, col 5, Warning - Rule is empty.
       
      /Users/danp/moodles/pm/moodle/theme/base/style/filemanager.css: line 21, col 20, Error - Duplicate property 'filter' found.
      /Users/danp/moodles/pm/moodle/theme/base/style/filemanager.css: line 21, col 118, Error - Duplicate property 'background' found.
      /Users/danp/moodles/pm/moodle/theme/base/style/filemanager.css: line 108, col 49, Warning - float can't be used with display: inline-block.
      /Users/danp/moodles/pm/moodle/theme/base/style/filemanager.css: line 315, col 38, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/theme/base/style/filemanager.css: line 315, col 67, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/theme/base/style/filemanager.css: line 315, col 109, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/theme/base/style/filemanager.css: line 315, col 147, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/theme/base/style/filemanager.css: line 316, col 56, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/theme/base/style/filemanager.css: line 317, col 57, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/theme/base/style/filemanager.css: line 465, col 73, Warning - Unknown property 'y-scroll'.
       
      /Users/danp/moodles/pm/moodle/theme/base/style/grade.css: line 214, col 1, Warning - Rule is empty.
       
      /Users/danp/moodles/pm/moodle/theme/base/style/message.css: line 12, col 1, Warning - Rule is empty.
       
      /Users/danp/moodles/pm/moodle/theme/base/style/pagelayout.css: line 82, col 36, Warning - Use of !important
       
      /Users/danp/moodles/pm/moodle/theme/canvas/style/core.css: line 365, col 1, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/canvas/style/core.css: line 471, col 5, Warning - Use of !important
      /Users/danp/moodles/pm/moodle/theme/canvas/style/core.css: line 497, col 5, Warning - Use of !important
       
      /Users/danp/moodles/pm/moodle/theme/canvas/style/course.css: line 99, col 5, Warning - display:inline has no effect on floated elements (but may be used to fix the IE6 double-margin bug).
      /Users/danp/moodles/pm/moodle/theme/canvas/style/course.css: line 106, col 1, Warning - Rule is empty.
      /Users/danp/moodles/pm/moodle/theme/canvas/style/course.css: line 112, col 1, Warning - Rule is empty.
       
      /Users/danp/moodles/pm/moodle/theme/canvas/style/mods.css: line 104, col 5, Warning - Use of !important
       
      /Users/danp/moodles/pm/moodle/theme/canvas/style/popups.css: line 2, col 5, Warning - Use of !important
       
      /Users/danp/moodles/pm/moodle/theme/clean/style/custom.css: line 52, col 2, Error - Expected IDENT at line 52, col 2.
      /Users/danp/moodles/pm/moodle/theme/clean/style/custom.css: line 52, col 2, Error - Expected IDENT at line 52, col 2.
       
      /Users/danp/moodles/pm/moodle/theme/more/style/custom.css: line 52, col 2, Error - Expected IDENT at line 52, col 2.
      /Users/danp/moodles/pm/moodle/theme/more/style/custom.css: line 52, col 2, Error - Expected IDENT at line 52, col 2.
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16