Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54702

Support standard icon element when importing LTI cartridges

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites:

      1. You must have a single course with a teacher enrolled.
      2. You must have downloaded the 4 test cartridges and placed then somewhere under your localhost. We'll need to upload these for the tests below.
        Test cartridges are as follows:
        • Standard and extension icons (CART1)
        • Extension icon only (CART2)
        • Standard icon only (CART3)
        • No icons (CART4)

      Testing steps:

      As a site admin:

      1. Navigate to External Tools (Site admin > plugins > activity modules > external tool > manage tools)
      2. Now, for each of the 4 cartridges:
        • Paste the URL (e.g. http://localhost/your_name.xml) into the 'Tool URL' field in the main 'Add tool' box and click 'Add'.
        • Confirm that:
          • CART 1 results in a tool with the moodle icon.
          • CART 2 results in a tool with the cat icon.
          • CART 3 results in a tool with the moodle icon.
          • CART 4 results in the default icon (puzzle piece).
      3. Delete the 4 tools from the 'Manage tools' page.
      4. Again, for each of the 4 cartridges:
        • Click on the 'Configure a tool manually' link.
        • Name the tool, paste in your cartridge url and save
        • Confirm that:
          • For all cartridges, the resulting tool has the default icon (puzzle piece).
      5. Delete all tools from the 'Manage tools' page.

      Now, as a teacher:

      1. Navigate to course home and enable editing.
      2. Now, for each of the 4 cartridges:
        • Click 'Add an activity or resource'.
        • Choose 'External tool' and click 'Add'.
        • Name the tool and paste your cartridge URL into the 'Launch/cartridge URL' field.
        • Click 'Save and return to course'.
        • Confirm that:
          • CART 1 results in a tool with the moodle icon.
          • CART 2 results in a tool with the cat icon.
          • CART 3 results in a tool with the moodle icon.
          • CART 4 results in the default icon (puzzle piece).
      3. Remove the 4 tools from the course.
      4. Again, for each of the 4 cartridges:
        • Click 'Add an activity or resource'.
        • Choose 'External tool' and click 'Add'.
        • Name the tool (eg Tool 1,2,3,4) and then click the plus symbol next to the 'Preconfigured tool' field. This should open in a new tab.
        • Name the type (eg Type 1,2,3,4) and paste your cartridge URL into the 'Tool base URL/cartridge URL' field.
        • Click 'Save changes'. You should be taken back to the original tab (the 'Adding a new external tool' page).
        • Confirm that the 'Preconfigured tool' field is set to the your type (eg Type 1)
        • Leave the Launch/cartridge URL field blank if it's enabled. This is a known bug and an issue will have already been created.
        • Click 'Save and return to course'.
        • Confirm that:
          • CART 1 results in a tool with the moodle icon.
          • CART 2 results in a tool with the cat icon.
          • CART 3 results in a tool with the moodle icon.
          • CART 4 results in the default icon (puzzle piece).
      Show
      Prerequisites: You must have a single course with a teacher enrolled. You must have downloaded the 4 test cartridges and placed then somewhere under your localhost. We'll need to upload these for the tests below. Test cartridges are as follows: Standard and extension icons (CART1) Extension icon only (CART2) Standard icon only (CART3) No icons (CART4) Testing steps: As a site admin: Navigate to External Tools (Site admin > plugins > activity modules > external tool > manage tools) Now, for each of the 4 cartridges: Paste the URL (e.g. http://localhost/your_name.xml ) into the 'Tool URL' field in the main 'Add tool' box and click 'Add'. Confirm that: CART 1 results in a tool with the moodle icon. CART 2 results in a tool with the cat icon. CART 3 results in a tool with the moodle icon. CART 4 results in the default icon (puzzle piece). Delete the 4 tools from the 'Manage tools' page. Again, for each of the 4 cartridges: Click on the 'Configure a tool manually' link. Name the tool, paste in your cartridge url and save Confirm that: For all cartridges, the resulting tool has the default icon (puzzle piece). Delete all tools from the 'Manage tools' page. Now, as a teacher: Navigate to course home and enable editing. Now, for each of the 4 cartridges: Click 'Add an activity or resource'. Choose 'External tool' and click 'Add'. Name the tool and paste your cartridge URL into the 'Launch/cartridge URL' field. Click 'Save and return to course'. Confirm that: CART 1 results in a tool with the moodle icon. CART 2 results in a tool with the cat icon. CART 3 results in a tool with the moodle icon. CART 4 results in the default icon (puzzle piece). Remove the 4 tools from the course. Again, for each of the 4 cartridges: Click 'Add an activity or resource'. Choose 'External tool' and click 'Add'. Name the tool (eg Tool 1,2,3,4) and then click the plus symbol next to the 'Preconfigured tool' field. This should open in a new tab. Name the type (eg Type 1,2,3,4) and paste your cartridge URL into the 'Tool base URL/cartridge URL' field. Click 'Save changes'. You should be taken back to the original tab (the 'Adding a new external tool' page). Confirm that the 'Preconfigured tool' field is set to the your type (eg Type 1) Leave the Launch/cartridge URL field blank if it's enabled. This is a known bug and an issue will have already been created. Click 'Save and return to course'. Confirm that: CART 1 results in a tool with the moodle icon. CART 2 results in a tool with the cat icon. CART 3 results in a tool with the moodle icon. CART 4 results in the default icon (puzzle piece).
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54702_master
    • Sprint:
      3.2 Sprint 1

      Description

      Erroneously, we supported the custom icon and secure icon extension properties, instead of the standard blti:icon and blti:secure_icon.

      We should fix this in a backwards compatible manner by supporting both the standard way and the extension. Preferring the standard way if both a present.

      https://www.imsglobal.org/specs/ltiv2p0/implementation-guide#toc-9

        Attachments

        1. CART1.xml
          2 kB
        2. CART2.xml
          2 kB
        3. CART3.xml
          2 kB
        4. CART4.xml
          1 kB
        5. cat.png
          cat.png
          23 kB
        6. moodle_icon.png
          moodle_icon.png
          4 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Jul/16