Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54712

Remove headings from LTI admin interface

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Setup
      1. Download and install ngrok and run it with
        ngrok http 80
      2. Set your wwwroot to use that url. e.g. https://asdfasdf.ngrok.io/integration_master/
      3. Go to Site administration ► Plugins ► Activity modules ► External tool ► Manage tools
      Cartridge registration
      1. For the Tool URL..., enter an XML cartridge URL. (i.e. https://www.edu-apps.org/lti_public_resources/config.xml?id=youtube)
      2. Click Add
      3. Enter consumer key and shared secret, if necessary, then click Save changes.
        • Confirm that a notification is shown.
      4. Check the notification.
        • Confirm that it does not contain a heading.
      5. Using your browser's dev tools, inspect the notification message.
        • Confirm that the message is not enclosed in p tags.
      6. Repeat the above steps, but this time, enter a URL for an invalid cartridge (i.e. http://www.w3schools.com/xml/note.xml).
        • Confirm that an error notification is shown.
      7. Check the notification.
        • Confirm that it does not contain a heading.
      8. Using your browser's dev tools, inspect the notification message.
        • Confirm that the message is not enclosed in p tags.
      External tool registration
      1. Add a tool by entering a configuration URL. (i.e. https://online.dr-chuck.com/sakai-api-test/tp.php, then clicking Continue to launch_presentation_url at the bottom of the frame, then clicking Yes for Are you sure you would like to activate this tool?)
        • Confirm that a notification is shown.
      2. Check the notification.
        • Confirm that it does not contain a heading.
      3. Using your browser's dev tools, inspect the notification message.
        • Confirm that the message is not enclosed in p tags.
      4. Enter the same configuration URL again.
        • Confirm that an error notification is shown.
      5. Check the notification.
        • Confirm that it does not contain a heading.
      6. Using your browser's dev tools, inspect the notification message.
        • Confirm that the message is not enclosed in p tags.
      Show
      Setup Download and install ngrok and run it with ngrok http 80 Set your wwwroot to use that url. e.g. https://asdfasdf.ngrok.io/integration_master/ Go to Site administration ► Plugins ► Activity modules ► External tool ► Manage tools Cartridge registration For the Tool URL... , enter an XML cartridge URL. (i.e. https://www.edu-apps.org/lti_public_resources/config.xml?id=youtube ) Click Add Enter consumer key and shared secret, if necessary, then click Save changes . Confirm that a notification is shown. Check the notification. Confirm that it does not contain a heading. Using your browser's dev tools, inspect the notification message. Confirm that the message is not enclosed in p tags. Repeat the above steps, but this time, enter a URL for an invalid cartridge (i.e. http://www.w3schools.com/xml/note.xml ). Confirm that an error notification is shown. Check the notification. Confirm that it does not contain a heading. Using your browser's dev tools, inspect the notification message. Confirm that the message is not enclosed in p tags. External tool registration Add a tool by entering a configuration URL. (i.e. https://online.dr-chuck.com/sakai-api-test/tp.php , then clicking Continue to launch_presentation_url at the bottom of the frame, then clicking Yes for Are you sure you would like to activate this tool? ) Confirm that a notification is shown. Check the notification. Confirm that it does not contain a heading. Using your browser's dev tools, inspect the notification message. Confirm that the message is not enclosed in p tags. Enter the same configuration URL again. Confirm that an error notification is shown. Check the notification. Confirm that it does not contain a heading. Using your browser's dev tools, inspect the notification message. Confirm that the message is not enclosed in p tags.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-54712-master
    • Sprint:
      3.2 Sprint 1

      Description

      The new LTI admin interface simply adds header HTML to the text given to the notification which is bad, and inconveniences themers a lot. We need to remove these headings.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              johno John Okely
              Peer reviewer:
              cameron1729 cameron1729
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Rajesh Taneja Rajesh Taneja
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/16