Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54734

Forum email digest sender name change following upgrade to 3.1

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Setup
      • Your moodle site should send emails.
      • Ensure that forum_replytouser is set to false
      • Your moodle users should have valid email addresses.
      • Other language pack installed, at least 2 more.
      Test
      1. Create a course with a teacher and a student.
      2. Create a forum. Set the Subscription mode to Forced subscription
      3. Login as a student.
      4. Go to Preferences ► User account ► Preferred language
      5. Change the preferred language to a different value to that of the system language.
      6. Logout then login as a teacher.
      7. Go to Preferences ► User account ► Preferred language
      8. Change the preferred language to a different value to that of the system language and to the student's preferred language.
      9. Go to the forum, post something. Make sure to tick Send forum post notifications with no editing-time delay
      10. Open a terminal, run

        php admin/cli/cron.php
        

      11. Check the email received by the teacher
        • Confirm that the "From" name is set to the equivalent of the "Do not reply to this email" on the teacher's preferred language.
      12. Check the email received by the student
        • Confirm that the "From" name is set to the equivalent of the "Do not reply to this email" on the student's preferred language.
      Show
      Setup Your moodle site should send emails. Ensure that forum_replytouser is set to false Your moodle users should have valid email addresses. Other language pack installed, at least 2 more. Test Create a course with a teacher and a student. Create a forum. Set the Subscription mode to Forced subscription Login as a student. Go to Preferences ► User account ► Preferred language Change the preferred language to a different value to that of the system language. Logout then login as a teacher. Go to Preferences ► User account ► Preferred language Change the preferred language to a different value to that of the system language and to the student's preferred language. Go to the forum, post something. Make sure to tick Send forum post notifications with no editing-time delay Open a terminal, run php admin/cli/cron.php Check the email received by the teacher Confirm that the "From" name is set to the equivalent of the " Do not reply to this email " on the teacher's preferred language. Check the email received by the student Confirm that the "From" name is set to the equivalent of the " Do not reply to this email " on the student's preferred language.
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54734-master
    • Sprint:
      3.2 Sprint 2

      Description

      When multiple users subscribed to the forum, and some have different languages set, the name of the no-reply user is always in the language of the first recipient.

      This is because we cache the dummy user record which we use to create the noreply user (and the support user), and we include the following in the cached content:

      $dummyuser->firstname = get_string('noreplyname');
      

      As a result, the string is translated before it is cached, and the translated version is then always used.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Jul/16