Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54745

Remove changegradewarning string and init_grade_change functions from mod_assign

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      This issue only removes leftover code, which is not being callled anywhere (provided MDL-53392 is integrated first!).

      To be thorough however, please follow the testing instructions from MDL-53392, which I've included (changed to suit master only) below:

      Prerequisites:
      You must have a course with a student enrolled.

      Test Steps:
      As an admin user:

      1. Navigate to your course home page
      2. Turn editing on
      3. Create a new assignment with default settings
      4. Assign a grade to the enrolled student for the assignment you just created
      5. Disable javascript
      6. Navigate back to course home and edit your assignment settings
      7. Scroll to the 'Grade' section and confirm that:
        a) The grade field is accompanied by the message - "Some grades have already been awarded, so the grade type cannot be changed. If you wish to change the maximum grade, you must first choose whether or not to rescale existing grades."
        b) There are no other messages/text warnings presented in the Grade section.
        c) The 'Maximum Grade' field IS editable.
      8. Change the maximum grade to 10000 but leave the 'Rescale existing grades' select set to 'Choose'.
      9. Save the form
      10. Confirm that the form fails validation
      11. Change the maximum grade to 50 and change the 'Rescale existing grades' select set to 'Yes'.
      12. Save the form
      13. Confirm that the form saves successfully
      14. Enable javascript
      15. Navigate back to course home and edit your assignment settings
      16. Scroll to the 'Grade' section and confirm that:
        a) The grade field is accompanied by the message - "Some grades have already been awarded, so the grade type cannot be changed. If you wish to change the maximum grade, you must first choose whether or not to rescale existing grades."
        b) There are no other messages/text warnings presented in the Grade section.
        c) The 'Maximum Grade' field IS NOT editable.
      17. Change the 'Maximum grade' to 80 and change the 'Rescale existing grades' select set to 'Yes'.
      18. Save the form
      19. Confirm that the form saves successfully
      Show
      This issue only removes leftover code, which is not being callled anywhere (provided MDL-53392 is integrated first!). To be thorough however, please follow the testing instructions from MDL-53392 , which I've included (changed to suit master only) below: Prerequisites: You must have a course with a student enrolled. Test Steps: As an admin user: Navigate to your course home page Turn editing on Create a new assignment with default settings Assign a grade to the enrolled student for the assignment you just created Disable javascript Navigate back to course home and edit your assignment settings Scroll to the 'Grade' section and confirm that : a) The grade field is accompanied by the message - " Some grades have already been awarded, so the grade type cannot be changed. If you wish to change the maximum grade, you must first choose whether or not to rescale existing grades. " b) There are no other messages/text warnings presented in the Grade section. c) The 'Maximum Grade' field IS editable. Change the maximum grade to 10000 but leave the 'Rescale existing grades' select set to 'Choose'. Save the form Confirm that the form fails validation Change the maximum grade to 50 and change the 'Rescale existing grades' select set to 'Yes'. Save the form Confirm that the form saves successfully Enable javascript Navigate back to course home and edit your assignment settings Scroll to the 'Grade' section and confirm that : a) The grade field is accompanied by the message - " Some grades have already been awarded, so the grade type cannot be changed. If you wish to change the maximum grade, you must first choose whether or not to rescale existing grades. " b) There are no other messages/text warnings presented in the Grade section. c) The 'Maximum Grade' field IS NOT editable. Change the 'Maximum grade' to 80 and change the 'Rescale existing grades' select set to 'Yes'. Save the form Confirm that the form saves successfully
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54745_master

      Description

      Originally discussed in MDL-53392, the string changegradewarning is no longer required due to changes to the interface introduced in 3.1. This issue has been created to remove it, along with a js function that used it, for master only. To be actioned after the 3.1 on-sync period ends.

      This string was originally used as:

      • A warning message in a <noscript> tag on mod/assign/mod_form.php and
      • In an alert message in mod/assign/module.js, fired after a change to the 'Max grade' field when editing an assignment.
        however, all references to this string and function were removed in MDL-53392.

      The string and the function are to be removed from master only.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jaked Jake Dallimore
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              cameron1729
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/16