Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54756

rtrim added to moodle_url::make_file_url by MDL-50268 causes regressions

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • 3.1.1
    • 3.1
    • Libraries

    Description

      See https://moodle.org/mod/forum/discuss.php?d=333805#p1344743

      MDL-50268 added an rtrim, just based on one comment by dobedobedoh (https://tracker.moodle.org/browse/MDL-50268?focusedCommentId=390990&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-390990), and without any further discussion. This breaks STACK, so I think we need to revert it. Hence this patch.

      Attachments

        Issue Links

          Activity

            People

              timhunt Tim Hunt
              timhunt Tim Hunt
              Simey Lameze Simey Lameze
              Andrew Lyons Andrew Lyons
              Damyon Wiese Damyon Wiese
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.