Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54756

rtrim added to moodle_url::make_file_url by MDL-50268 causes regressions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1.1
    • Component/s: Libraries
    • Labels:

      Description

      See https://moodle.org/mod/forum/discuss.php?d=333805#p1344743

      MDL-50268 added an rtrim, just based on one comment by Andrew Lyons (https://tracker.moodle.org/browse/MDL-50268?focusedCommentId=390990&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-390990), and without any further discussion. This breaks STACK, so I think we need to revert it. Hence this patch.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Simey Lameze Simey Lameze
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Damyon Wiese Damyon Wiese
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/16