Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54761

Data loss when submitting rubric form after session time-out (rubric grading)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Development in progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.9.6, 3.3.3, 3.4
    • Fix Version/s: None
    • Component/s: Assignment
    • Testing Instructions:
      Hide

      Manual testing

      1. As admin create teacher1, student1
      2. Create a course Course1 and enroll teacher1 as teacher and student1 as student in the course.
      3. Login as teacher1 and create an assignment "Assignment1" in Course1.
        1. Make sure to have "Grade" -> "Grading method" selected as "Rubric"

        2. Click "Save and display".
        3. You should see the advanced grading page now.
        4. Now let's click on "Define new grading from scratch".
        5. Give a name to the rubric
        6. Now click on "Click to edit criterion"
        7. Add as many criterion you like for instance:
             a. Grammer, Poor(in click to edit level), Ok (in next click to edit level), Good (in next click to edit level)
              b. Style, Poor, Ok, Good, etc
        8. Now click on "Save rubric and make it ready".
      4. Now log in as student1
         1. Go to Course1
         2. Navigate to the
        "Assignment1"
         3. Submit some data in the assignment.
      5. Now as admin, set `$CFG->sessiontimeout = 80;` in config.php
        # Now login as teacher1.
      6. Navigate to "Course1" > "Assignment1"  and click the "Grade" button at the bottom.
      7. Click on the rubrics criterion you see also share some feedback on the text area( not in the atto editor)
      8. Do not click on the "Save changes" button and wait for 1 minute or 60 seconds.
      9. You should see the page reload with the message "The changes to the grade and feedback were saved".
      Show
      Manual testing As admin create teacher1, student1 Create a course Course1 and enroll teacher1 as teacher and student1 as student in the course. Login as teacher1 and create an assignment "Assignment1" in Course1. 1. Make sure to have "Grade" -> "Grading method" selected as "Rubric" 2. Click "Save and display". 3. You should see the advanced grading page now. 4. Now let's click on "Define new grading from scratch". 5. Give a name to the rubric 6. Now click on "Click to edit criterion" 7. Add as many criterion you like for instance:      a. Grammer, Poor(in click to edit level), Ok (in next click to edit level), Good (in next click to edit level)       b. Style, Poor, Ok, Good, etc 8. Now click on "Save rubric and make it ready". Now log in as student1  1. Go to Course1  2. Navigate to the "Assignment1"  3. Submit some data in the assignment. Now as admin, set ` $CFG->sessiontimeout = 80; ` in config.php # Now login as teacher1. Navigate to "Course1" > "Assignment1"  and click the "Grade" button at the bottom. Click on the rubrics criterion you see also share some feedback on the text area( not in the atto editor) Do not click on the "Save changes" button and wait for 1 minute or 60 seconds. You should see the page reload with the message "The changes to the grade and feedback were saved".
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull 3.11 Branch:
      MDL-54761-311
    • Pull Master Branch:
      MDL-54761-master
    • Story Points:
      3
    • Sprint:
      4.0 Navigation blitz 2

      Description

      I have a homework that takes some time to grade using a rubric, and I've been bitten by this bug more than once. If the form is not submitted within a certain time (which seems arbitrary to me, since my university is using a single-sign-on cookie), the session key is no longer valid and I get the message "Incorrect sesskey submitted, form not accepted!"

      The bug is the fact that there is no recovery from this situation and there is data loss (in a 12-criteria rubric with feedback it's painful).

      Shouldn't we be asked to re-authenticate, and then have the form contents be properly submitted, similar to how it works when I try to access a page when I'm not authenticated.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sujith Sujith Haridasan
              Reporter:
              fuhrmanator Christopher Fuhrman
              Peer reviewer:
              Mihail Geshoski Mihail Geshoski
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 days, 1 minute
                  3d 1m