Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54782

Deprecate/remove any unused lang strings in core

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide
      Test 1
      1. Look at the diff and confirm the strings that were removed are no longer used.
      Test 2

      <?php
       
      require_once('config.php');
       
      echo get_string('context', 'message');
      echo get_string('discussion', 'message');
      echo get_string('emptysearchstring', 'message');
      echo get_string('formorethan', 'message');
      echo get_string('keywords', 'message');
      echo get_string('messagehistory', 'message');
      echo get_string('newsearch', 'message');
      echo get_string('nosearchresults', 'message');
      echo get_string('onlymycourses', 'message');
      echo get_string('pagerefreshes', 'message');
      echo get_string('page-message-x', 'message');
      echo get_string('recent', 'message');
      echo get_string('savemysettings', 'message');
      echo get_string('search', 'message');
      echo get_string('settingssaved', 'message');
      echo get_string('strftimedaydatetime', 'message');
      echo get_string('timenosee', 'message');
      echo get_string('timesent', 'message');
      echo get_string('userssearchresults', 'message');
      

      1. Put the above code in test.php in your wwwroot.
      2. Visit <yoursite>/test.php.
      3. Confirm you get the correct number of debugging messages.
      Show
      Test 1 Look at the diff and confirm the strings that were removed are no longer used. Test 2 <?php   require_once('config.php');   echo get_string('context', 'message'); echo get_string('discussion', 'message'); echo get_string('emptysearchstring', 'message'); echo get_string('formorethan', 'message'); echo get_string('keywords', 'message'); echo get_string('messagehistory', 'message'); echo get_string('newsearch', 'message'); echo get_string('nosearchresults', 'message'); echo get_string('onlymycourses', 'message'); echo get_string('pagerefreshes', 'message'); echo get_string('page-message-x', 'message'); echo get_string('recent', 'message'); echo get_string('savemysettings', 'message'); echo get_string('search', 'message'); echo get_string('settingssaved', 'message'); echo get_string('strftimedaydatetime', 'message'); echo get_string('timenosee', 'message'); echo get_string('timesent', 'message'); echo get_string('userssearchresults', 'message'); Put the above code in test.php in your wwwroot. Visit <yoursite>/test.php. Confirm you get the correct number of debugging messages.
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54782_master

      Description

      Some strings may no longer be used - deprecate them.

        Attachments

          Activity

            People

            Assignee:
            markn Mark Nelson
            Reporter:
            markn Mark Nelson
            Peer reviewer:
            Simey Lameze
            Integrator:
            Dan Poltawski
            Tester:
            Rajesh Taneja
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              5/Dec/16