Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.1, 3.1 regressions
-
Fix Version/s: 3.1.3
-
Component/s: Web Services
-
Testing Instructions:
-
Affected Branches:MOODLE_31_STABLE
-
Fixed Branches:MOODLE_31_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-54793-master -
Pull Master Diff URL:
Description
3.1 XML-RPC implementation merges the $_GET and $_POST variables into the "$methodvariables" variable, using this last ones as arguments of the function call.
This breaks the process, since :
- $_GET can contain other params, not necessarily related with XML-RPC request
- $_POST is wrong, since PHP waits for a "key=val" string, where XML-RPC waits for the XML code only as HTTP request body
The problem seem to be solvable by resetting "$methodvariables" to an empty array, in "/webservice/xmlrpc/locallib.php", line 74 (just before the $rawpostdata = file_get_contents("php://input"))
This trouble has been discovered after using webservices with 3.0 for several weeks, with no problems. After upgrade to 3.1, XML-RPC process was throwing errors, despite the fact that the XML-RPC client was the same, with the same Moodle configuration.
Attachments
Issue Links
- is a regression caused by
-
MDL-52209 Remove Zend XML-RPC from Moodle's XML-RPC web service
-
- Closed
-