Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54796

Cannot switch between students in assignment grading interface

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.1, 3.1 regressions
    • Fix Version/s: 3.1.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      This test is to check that you are not hindered with an unnecessary dialogue when just browsing pages with a text editor.

      • Make sure that you are using Atto for this test.
      • Don't auto create your course with the test course creator in the developer tools.

      Assignment Setup

      1. To speed things up we are increasing the time that atto autosaves text.
        • Go to [Site administration  ► Plugins  ► Text editors  ► Atto HTML editor  ► Atto toolbar settings] > Autosave frequency. I set mine to 10 seconds.
      2. Create an assignment.
        • Under "Feedback types" check that "Feedback comments" is checked.
      3. Click on Grade (An actual submission from a student is not required).
      4. Ensure that you are using the new grader interface.
      5. Enter some text in feedback comments editor. Wait until you see a message saying that atto saved a draft.
      6. Now navigate away via the links in the top left corner (Course link or Assignment link).
      7. You will see a message asking if you want to leave this site. Click leave.

      Assignment testing

      1. Click "Grade" in the assignment again.
      2. The draft should be restored in the feedback comments.
      3. Change the user (top right corner)
      4. Test that you do not receive a message saying that there are unsaved changes.
      5. Test that you can click the course or assignment link in the top left corner and you do not see a message about leaving the site.
      6. Add some additional text to the feedback and wait for the draft to save.
      7. Try to change the user.
      8. Test that you now do receive a message about unsaved changes.
      9. Test that when clicking the assignment or course link (top left) that you see a message about leaving the site.
      10. Click the reset button.
      11. Test that after reseting the page that you can navigate away without seeing a message.

      General testing setup

      1. Go to the settings page of a course.
      2. Check that your course summary is using the Atto editor. If not then edit an activity and update the description instead.
      3. Enter some text in the "Course summary". Wait for the draft to save.
      4. Navigate away (don't save). You should see a message asking if you want to leave the site. Click leave.

      General testing

      1. Go back to the settings page for the course.
      2. The draft text should be restored.
      3. Test that you can navigate away (no saving) and that you do not see a message about leaving the site.
      4. Edit the course summary (still no saving).
      5. Test that navigating away now does show a message about leaving the site.
      Show
      This test is to check that you are not hindered with an unnecessary dialogue when just browsing pages with a text editor. Make sure that you are using Atto for this test. Don't auto create your course with the test course creator in the developer tools. Assignment Setup To speed things up we are increasing the time that atto autosaves text. Go to [Site administration  ► Plugins  ► Text editors  ► Atto HTML editor  ► Atto toolbar settings] > Autosave frequency. I set mine to 10 seconds. Create an assignment. Under "Feedback types" check that "Feedback comments" is checked. Click on Grade (An actual submission from a student is not required). Ensure that you are using the new grader interface. Enter some text in feedback comments editor. Wait until you see a message saying that atto saved a draft. Now navigate away via the links in the top left corner (Course link or Assignment link). You will see a message asking if you want to leave this site. Click leave. Assignment testing Click "Grade" in the assignment again. The draft should be restored in the feedback comments. Change the user (top right corner) Test that you do not receive a message saying that there are unsaved changes. Test that you can click the course or assignment link in the top left corner and you do not see a message about leaving the site. Add some additional text to the feedback and wait for the draft to save. Try to change the user. Test that you now do receive a message about unsaved changes. Test that when clicking the assignment or course link (top left) that you see a message about leaving the site. Click the reset button. Test that after reseting the page that you can navigate away without seeing a message. General testing setup Go to the settings page of a course. Check that your course summary is using the Atto editor. If not then edit an activity and update the description instead. Enter some text in the "Course summary". Wait for the draft to save. Navigate away (don't save). You should see a message asking if you want to leave the site. Click leave. General testing Go back to the settings page for the course. The draft text should be restored. Test that you can navigate away (no saving) and that you do not see a message about leaving the site. Edit the course summary (still no saving). Test that navigating away now does show a message about leaving the site.
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-54796-master-v2
    • Story Points:
      4
    • Sprint:
      3.2 Sprint 3

      Description

      Reproduced with Firefox, not with Chrome.

      1. Set Atto autosave frequency to 10 seconds
      2. Go to an assignment with participants
      3. Open the grader
      4. Type some text in the feedback and wait for Atto to save the draft
      5. Try to switch to another user
      6. You are warned of unsaved changes, do not save
      7. Click Reset at the bottom of the page
      8. Try to switch to another user

      Expected

      • Respect the same behaviour as Chrome, the view switches to the new user

      Actual

      • The same message as earlier warns you about unsaved changes, you cannot leave the page.

        Attachments

          Activity

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Sep/16