Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54842

Additional HTML conflicts with Assignment grading page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.4, 3.1
    • Fix Version/s: 3.0.5, 3.1.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      Setup
      1. Create a course.
      2. Enrol some students.
      3. Create an assignment
      4. Navigate to Site administration ► Appearance ► Additional HTML
      5. Under When BODY is opened enter the following: 

        <h5>ADDITIONAL TOP OF BODY HTML</h5>

      6. Under Before BODY is closed enter the following: 

        <h5>ADDITIONAL HTML FOOTER</h5>

      7. Click Save changes
      8. After the page refresh, check the top and bottom parts of the page.
        • Confirm that ADDITIONAL TOP OF BODY HTML and ADDITIONAL HTML FOOTER are rendered on the top and bottom parts of the page, respectively.
      For 3.1 and master
      1. Navigate to the assignment.
      2. Grade a student.
      3. Check the grading page's layout.
        • Confirm that ADDITIONAL TOP OF BODY HTML and ADDITIONAL HTML FOOTER are NOT being rendered anywhere on the page.
      For 3.0, 3.1 and master
      1. Turn off JavaScript for the browser.
      2. Under the assignment's administration block, click Edit settings
      3. Check the layout of the embedded file chooser for the Additional files field.
        • Confirm that ADDITIONAL TOP OF BODY HTML and ADDITIONAL HTML FOOTER are NOT being rendered anywhere within the embedded content.
      Show
      Setup Create a course. Enrol some students. Create an assignment Navigate to Site administration ► Appearance ► Additional HTML Under When BODY is opened enter the following: <h5>ADDITIONAL TOP OF BODY HTML</h5> Under Before BODY is closed enter the following: <h5>ADDITIONAL HTML FOOTER</h5> Click Save changes After the page refresh, check the top and bottom parts of the page. Confirm that ADDITIONAL TOP OF BODY HTML and ADDITIONAL HTML FOOTER are rendered on the top and bottom parts of the page, respectively. For 3.1 and master Navigate to the assignment. Grade a student. Check the grading page's layout. Confirm that ADDITIONAL TOP OF BODY HTML and ADDITIONAL HTML FOOTER are NOT being rendered anywhere on the page. For 3.0, 3.1 and master Turn off JavaScript for the browser. Under the assignment's administration block, click Edit settings Check the layout of the embedded file chooser for the Additional files field. Confirm that ADDITIONAL TOP OF BODY HTML and ADDITIONAL HTML FOOTER are NOT being rendered anywhere within the embedded content.
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54842-master
    • Pull Master Diff URL:
    • Sprint:
      3.2 Sprint 1

      Description

      Whenever in Moodle 3.1 we add additional HTML such as Text, images etc from Administration > Site administration > Appearance > Additional HTML it conflict with the Assignment Grading page.
      The text and images overlap with the page header.

        Attachments

          Activity

            People

            Assignee:
            jpataleta Jun Pataleta
            Reporter:
            sakshi_moodler Sakshi Goel
            Peer reviewer:
            cameron1729
            Integrator:
            Dan Poltawski
            Tester:
            Adrian Greeve
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Jul/16