Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54852

"do you want to leave this page" dialogue on PDF grading screen even when saved

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Create a simple mod_assign instance (PDF grading not required) – e.g.: Submission "Online text", Feedback "Feedback comments".
      • As a student, submit something.
      • Start grading a submission by clicking on "Grade".
      • Type anything you like in the Feedback.
      • Click on the back button of the browser; verify that a "leaving page" warning is shown. Stay on the page!
      • Click save.
      • Click on the back button of the browser; verify that no warning is shown.
      Show
      Create a simple mod_assign instance (PDF grading not required) – e.g.: Submission "Online text", Feedback "Feedback comments". As a student, submit something. Start grading a submission by clicking on "Grade". Type anything you like in the Feedback. Click on the back button of the browser; verify that a "leaving page" warning is shown. Stay on the page! Click save. Click on the back button of the browser; verify that no warning is shown .
    • Affected Branches:
      MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      mdl-54852-master

      Description

      To reproduce...

      • set up PDF grading (I have unoconv working but uploading a PDF should be the same)
      • click Grade for a submission.
      • type anything you like in the Feedback and click save
      • a dialogue appears to say that it has been saved
      • click the course name on the breadcrumb trail

      Even though the page has been properly saved the "do you want to leave this page" dialogue is displayed. Mostly an annoyance but would be good to see it fixed.

      I tried this with Chrome on a Mac.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jan.dagefoerde Jan Dageförde
              Reporter:
              howardsmiller Howard Miller
              Peer reviewer:
              Damyon Wiese
              Integrator:
              David Monllaó
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              11 Vote for this issue
              Watchers:
              12 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Nov/16