Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 2.0.1
    • Component/s: Authentication
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      3216

      Description

      All authentication plugins currently (I last checked in 1.6 beta 1) use a single language file for the strings. This is quite anti-modular since adding custom plugins requires changing the core file. I believe that each auth plugin should use their own language file for its strings and the common auth lang file for strings common to all plugins. Unless that is, the intention is that all auth plugins are meant to be distributed only by mainstream Moodle developers.

      There are for example a few variations of the pop3 plugin. For example, I contributed pop3x (allowing to specify pop servers individually for each user) and somebody just posted instructions for pop3sub (allowing to require specific subdomain).

        Issue Links

          Activity

          Hide
          Martin Dougiamas added a comment -

          Bumping until later

          Show
          Martin Dougiamas added a comment - Bumping until later
          Hide
          Martín Langhoff added a comment -

          +1

          I am working with Jonathan Harker on an auth revamp, and he had split up and rationalised the lang strings for auth plugins. Looking at it, I asked him to undo it until we could talk with MartinD about it because I wasn't sure of the protocol involved in rearranging lang files. My concerns:

          • pushes a lot of work on to translators to follow suit (or maybe we should write a script to "replay" the split up for each language, based on the array keys, and perform the rearrangement for all of them?)
          • we need to deal with the STABLE branch somehow. Maybe the patch to the code needs to be applied there as well – or our strings handling needs to be branch aware. I dunno.

          if there's a clear path for both issues, we'll tackle it. MartinD?

          Show
          Martín Langhoff added a comment - +1 I am working with Jonathan Harker on an auth revamp, and he had split up and rationalised the lang strings for auth plugins. Looking at it, I asked him to undo it until we could talk with MartinD about it because I wasn't sure of the protocol involved in rearranging lang files. My concerns: pushes a lot of work on to translators to follow suit (or maybe we should write a script to "replay" the split up for each language, based on the array keys, and perform the rearrangement for all of them?) we need to deal with the STABLE branch somehow. Maybe the patch to the code needs to be applied there as well – or our strings handling needs to be branch aware. I dunno. if there's a clear path for both issues, we'll tackle it. MartinD?
          Hide
          Jonathan Harker added a comment -

          I could easily make a patch for this, having wandered off and done this already as part of the multiauth stuff I'm fiddling with at the moment - I just posted this:

          http://moodle.org/mod/forum/discuss.php?d=55143

          Show
          Jonathan Harker added a comment - I could easily make a patch for this, having wandered off and done this already as part of the multiauth stuff I'm fiddling with at the moment - I just posted this: http://moodle.org/mod/forum/discuss.php?d=55143
          Hide
          Martín Langhoff added a comment -

          Jonathan - we should get a good patch for this once the blocker is resolved...

          Show
          Martín Langhoff added a comment - Jonathan - we should get a good patch for this once the blocker is resolved...
          Hide
          Martin Dougiamas added a comment -

          Did anything happen with this?

          Show
          Martin Dougiamas added a comment - Did anything happen with this?
          Hide
          Martin Dougiamas added a comment -

          Yoo hoo!

          Show
          Martin Dougiamas added a comment - Yoo hoo!
          Hide
          Martín Langhoff added a comment -

          Hey - it has a blocker at the moment... (look in the blockers list at the top). In short, if we split the files they get split for HEAD and all the _STABLEs so we break the stables unless we

          • start tagging lang with the rest of the code (impacts on translator workflow)
          • or we apply a biiig patch to all the _STABLEs to match the change lang

          we are keen on the split, but if we do it without resolving this first, we'll get hit with a big stick I'm sure.

          Show
          Martín Langhoff added a comment - Hey - it has a blocker at the moment... (look in the blockers list at the top). In short, if we split the files they get split for HEAD and all the _STABLEs so we break the stables unless we start tagging lang with the rest of the code (impacts on translator workflow) or we apply a biiig patch to all the _STABLEs to match the change lang we are keen on the split, but if we do it without resolving this first, we'll get hit with a big stick I'm sure.
          Hide
          Petr Škoda added a comment -

          not enough time to change this before 1.8 final, sorry

          Show
          Petr Škoda added a comment - not enough time to change this before 1.8 final, sorry
          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this issue.

          We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

          If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

          Michael d;

          lqjjLKA0p6

          Show
          Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
          Hide
          Jonathan Harker added a comment -

          This is old hat! Fixed in 2.x

          Show
          Jonathan Harker added a comment - This is old hat! Fixed in 2.x

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: