Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54890

Some JS errors detected in course and assignfeedback_editpdf

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 3.0.4, 3.1, 3.2
    • 3.0.5, 3.1.1
    • JavaScript
    • MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • MOODLE_30_STABLE, MOODLE_31_STABLE
    • MDL-54890-master
    • Hide

      Ensure pdf annotations are setup on your site (ghostscript etc)

      1. As teacher
      2. Go to a course
      3. Turn editing on
      4. Duplicate an activity/resource
      5. VERIFY: it works, the activity is duplicated
      6. Add an assignment to the course with file upload
      7. As student, submit a pdf as your submission
      8. As teacher, grade that submission, annotating the pdf with some comments
      9. As a student, view the teachers response and ensure the pdf annotation comments are there
      Show
      Ensure pdf annotations are setup on your site (ghostscript etc) As teacher Go to a course Turn editing on Duplicate an activity/resource VERIFY: it works, the activity is duplicated Add an assignment to the course with file upload As student, submit a pdf as your submission As teacher, grade that submission, annotating the pdf with some comments As a student, view the teachers response and ensure the pdf annotation comments are there

    Description

      In MDL-52127 eslint detected some errors which need to be fixed before integrated - I was keeping them in the same issue, but in the end because they should be backported and are distincitive in testing I decided to create this bug to track them.

      Attachments

        Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-52127 Check Moodle JS coding style with eslint

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              poltawski Dan Poltawski
              poltawski Dan Poltawski
              Frédéric Massart Frédéric Massart
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Mark Nelson Mark Nelson
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/Jul/16