Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54921

$SESSION->wantsurl lost during registration

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Set up mail (can use mailcatcher)
      2. Use any theme until regression test
      3. As admin, enable self registration
      4. Log out
      5. Click to go to a page you don't have access to as a guest (e.g. course)
      6. Click sign up
      7. Enter details
      8. Check email
      9. Click confirm link
      10. You should redirect to the page you originally wanted to go to
      11. Log out
      12. Click to go to a page you don't have access to as a guest
      13. Click sign up
      14. Don't fill in the form, instead click log in
      15. Log in
      16. You should be redirected to the page you originally wanted to go to
      17. Regression test
      18. Log out (make sure you are on clean theme as the login link was removed from signup in boost)
      19. Go directly to login/signup.php
      20. Click login
      21. Log in
      22. Make sure you are not redirected back to login/signup.php
      Show
      Set up mail (can use mailcatcher) Use any theme until regression test As admin, enable self registration Log out Click to go to a page you don't have access to as a guest (e.g. course) Click sign up Enter details Check email Click confirm link You should redirect to the page you originally wanted to go to Log out Click to go to a page you don't have access to as a guest Click sign up Don't fill in the form, instead click log in Log in You should be redirected to the page you originally wanted to go to Regression test Log out (make sure you are on clean theme as the login link was removed from signup in boost) Go directly to login/signup.php Click login Log in Make sure you are not redirected back to login/signup.php
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_29_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-54921-master

      Description

      1. User tries to access a course with a direct link
      2. Accessing the course requires authentication, so user is redirected to login/registration page
      3. User creates a new account and confirms it
      4. User gets redirected to...

      • Expectation: the original URL (the course page)
      • Actual result: the front page

      5. The site may have hundreds or courses so now user has no idea where to find the correct course

      After this the user could of course click the link again, but most users don't realize this. Additionally it is bad usability to require clicking the link twice.

        Attachments

          Activity

            People

            Assignee:
            johno John Okely
            Reporter:
            juho.jaakkola Juho Jaakkola
            Peer reviewer:
            Jake Dallimore
            Integrator:
            Andrew Nicols
            Tester:
            Ryan Wyllie
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Barbara Ramiro, Bas Brands
            Votes:
            2 Vote for this issue
            Watchers:
            9 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Jan/17