Loading...

XML

Word

Printable

Affected Branches:
MOODLE_31_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Pull from Repository:
git://github.com/ryanwyllie/moodle.git
Pull Main Branch:
~~MDL-54935~~_m32v1
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...sbourget:MDL-54935_m32v1
Difficulty:
Easy
Testing Instructions:

Hide

1. Create a new survey
2. Complete / submit the survey activity
3. Verify that there is a single log entry for submitting the survey (Survey response submitted)
4. Run behat for mod_survey

Show
1. Create a new survey 2. Complete / submit the survey activity 3. Verify that there is a single log entry for submitting the survey (Survey response submitted) 4. Run behat for mod_survey

The response_submitted event is called twice when submitting a survey.
The first time is part of the survey_save_answers() function on line 69 of save.php
https://github.com/moodle/moodle/blob/master/mod/survey/save.php#L69
Which triggers the event here:
https://github.com/moodle/moodle/blob/master/mod/survey/lib.php#L1016

The second time is 7 lines later in save.php (The next 7 lines are setting up the event trigger)

Discovered while testing

MDL-48944 Survey should have activity completion condition on survey completed

Participants:: Andrew Lyons, CiBoT, Ryan Wyllie, Simey Lameze, Stephen Bourget