Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54939

Make AMD modules eslint warning free

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: 3.2
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Test real change to ajax call:
      Go to any course and in "Course administration -> Users -> Permissions" check that:
      1) Any role capability modification(clicking "+" or "x") leads to JS popup
      2) If you add any role to "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh
      3) If you remove any role from "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh

      Run:
      grunt eslint:amd --show-lint-warnings no warnings should be displayed apart from the annoying comment about ignored files (https://github.com/sindresorhus/grunt-eslint/issues/119)

      Show
      Test real change to ajax call: Go to any course and in "Course administration -> Users -> Permissions" check that: 1) Any role capability modification(clicking "+" or "x") leads to JS popup 2) If you add any role to "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh 3) If you remove any role from "Roles with permission" or "Prohibited" for any capability it is saved and persists in database after site refresh Run: grunt eslint:amd --show-lint-warnings no warnings should be displayed apart from the annoying comment about ignored files ( https://github.com/sindresorhus/grunt-eslint/issues/119 )
    • Affected Branches:
      MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-54939-master

      Description

      We need to fix the amd source files up so there are no more warnings left as Damyon requested.

      eslint --fix will do a lot of the job for us

      Edit: This issue was originally going to wait for MDLSITE-4628 - but given the extent of the diff, I think it's better if we get the current fixups in sooner.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16