Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-54970

Check for 0px when peer review / integrate / code check.

    XMLWordPrintable

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 2.9.6, 3.0.4, 3.1, 3.2
    • None
    • Policy, Themes
    • None
    • MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE

    Description

      It is considered wrong to have '0px' and instead just have '0' and whilst existing CSS should not be changed, when its does then it should be corrected. A recent example is MDL-54559 - discussion ref: https://moodle.org/mod/forum/discuss.php?d=335059.

      I thought that Code Checker checked against this?

      Attachments

        Activity

          People

            Unassigned Unassigned
            gb2048 Gareth J Barnard
            David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May
            Votes:
            5 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated: